From cd2215fd4a690f4ab055be8affd05f18ce8b4ec0 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 18 Apr 2019 05:30:07 -0700
Subject: [PATCH] Don't warn that workboard columns need a name when editing
 milestone columns

Summary: See <https://discourse.phabricator-community.org/t/columns-must-have-a-name-while-editong-point-limit-on-milestone-column/2650>. This check doesn't make sense for proxy columns, including milestone columns.

Test Plan: Added a point limit to a milestone column.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20448
---
 .../column/PhabricatorProjectColumnNameTransaction.php       | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php b/src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php
index bff54277de..4a7342dc5f 100644
--- a/src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php
+++ b/src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php
@@ -41,7 +41,10 @@ final class PhabricatorProjectColumnNameTransaction
     if ($this->isEmptyTextTransaction($object->getName(), $xactions)) {
       // The default "Backlog" column is allowed to be unnamed, which
       // means we use the default name.
-      if (!$object->isDefaultColumn()) {
+
+      // Proxy columns can't have a name, so don't raise an error here.
+
+      if (!$object->isDefaultColumn() && !$object->getProxy()) {
         $errors[] = $this->newRequiredError(
           pht('Columns must have a name.'));
       }