OAuth Server -- add a doc and link to it in a few places
Summary: add a big ole HELP tab and make "scope" link to the specific sub-section about scope Test Plan: read my doc a few times, it basically english verified links looked correct and should work right once this is all in production Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Maniphest Tasks: T910 Differential Revision: https://secure.phabricator.com/D1752
This commit is contained in:
@@ -47,6 +47,17 @@ extends PhabricatorController {
|
||||
$nav->appendChild($view);
|
||||
|
||||
$page->appendChild($nav);
|
||||
$doc_href = PhabricatorEnv::getDoclink(
|
||||
'article/Using_the_Phabricator_OAuth_Server.html'
|
||||
);
|
||||
$page->setTabs(
|
||||
array(
|
||||
'help' => array(
|
||||
'name' => 'Help',
|
||||
'href' => $doc_href,
|
||||
),
|
||||
),
|
||||
null);
|
||||
|
||||
$response = new AphrontWebpageResponse();
|
||||
return $response->setContent($page->render());
|
||||
|
||||
@@ -8,6 +8,7 @@
|
||||
|
||||
phutil_require_module('phabricator', 'aphront/response/webpage');
|
||||
phutil_require_module('phabricator', 'applications/base/controller/base');
|
||||
phutil_require_module('phabricator', 'infrastructure/env');
|
||||
phutil_require_module('phabricator', 'view/form/error');
|
||||
phutil_require_module('phabricator', 'view/layout/sidenavfilter');
|
||||
|
||||
|
||||
@@ -54,6 +54,9 @@ extends PhabricatorOAuthClientAuthorizationBaseController {
|
||||
$current_user);
|
||||
$updated = phabricator_datetime($authorization->getDateModified(),
|
||||
$current_user);
|
||||
$scope_doc_href = PhabricatorEnv::getDoclink(
|
||||
'article/Using_the_Phabricator_OAuth_Server.html#scopes'
|
||||
);
|
||||
$row = array(
|
||||
phutil_render_tag(
|
||||
'a',
|
||||
@@ -65,7 +68,7 @@ extends PhabricatorOAuthClientAuthorizationBaseController {
|
||||
phutil_render_tag(
|
||||
'a',
|
||||
array(
|
||||
'href' => 'TODO - link to scope about',
|
||||
'href' => $scope_doc_href,
|
||||
),
|
||||
$authorization->getScopeString()
|
||||
),
|
||||
|
||||
@@ -9,6 +9,7 @@
|
||||
phutil_require_module('phabricator', 'applications/oauthserver/controller/clientauthorization/base');
|
||||
phutil_require_module('phabricator', 'applications/oauthserver/storage/client');
|
||||
phutil_require_module('phabricator', 'applications/oauthserver/storage/clientauthorization');
|
||||
phutil_require_module('phabricator', 'infrastructure/env');
|
||||
phutil_require_module('phabricator', 'view/control/table');
|
||||
phutil_require_module('phabricator', 'view/form/error');
|
||||
phutil_require_module('phabricator', 'view/layout/panel');
|
||||
|
||||
Reference in New Issue
Block a user