From d0af617818b6f56bcf90a99e34b0be925bbaad02 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 13 Mar 2012 16:21:04 -0700 Subject: [PATCH] Add "final" to (almost) everything else Summary: Last of the big final patches. Left a few debatable classes (12 out of about 400) that I'll deal with individually eventually. Test Plan: Ran testEverythingImplemented. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T795 Differential Revision: https://secure.phabricator.com/D1881 --- .../configuration/DatabaseConfigurationProvider.php | 5 ++++- .../methodcalllog/PhabricatorConduitMethodCallLog.php | 4 ++-- .../herald/adapter/commit/HeraldCommitAdapter.php | 2 +- .../differential/HeraldDifferentialRevisionAdapter.php | 4 ++-- .../herald/adapter/dryrun/HeraldDryRunAdapter.php | 4 ++-- .../herald/config/action/HeraldActionConfig.php | 2 +- .../herald/config/condition/HeraldConditionConfig.php | 2 +- .../herald/config/contenttype/HeraldContentTypeConfig.php | 4 ++-- src/applications/herald/config/field/HeraldFieldConfig.php | 2 +- .../repetitionpolicy/HeraldRepetitionPolicyConfig.php | 4 ++-- .../herald/config/ruletype/HeraldRuleTypeConfig.php | 2 +- .../herald/config/valuetype/HeraldValueTypeConfig.php | 2 +- src/applications/herald/engine/effect/HeraldEffect.php | 4 ++-- src/applications/herald/engine/engine/HeraldEngine.php | 2 +- .../engine/exception/HeraldInvalidConditionException.php | 4 ++-- .../engine/exception/HeraldInvalidFieldException.php | 4 ++-- .../exception/HeraldRecursiveConditionsException.php | 4 ++-- src/applications/herald/storage/action/HeraldAction.php | 4 ++-- .../herald/storage/condition/HeraldCondition.php | 4 ++-- .../herald/storage/edithistory/HeraldRuleEdit.php | 2 +- src/applications/herald/storage/rule/HeraldRule.php | 2 +- .../storage/transcript/apply/HeraldApplyTranscript.php | 4 ++-- .../herald/storage/transcript/base/HeraldTranscript.php | 4 ++-- .../transcript/condition/HeraldConditionTranscript.php | 4 ++-- .../storage/transcript/object/HeraldObjectTranscript.php | 4 ++-- .../storage/transcript/rule/HeraldRuleTranscript.php | 4 ++-- .../typeexception/ManiphestAuxiliaryFieldTypeException.php | 4 ++-- .../ManiphestAuxiliaryFieldValidationException.php | 4 ++-- .../maniphest/constants/action/ManiphestAction.php | 4 ++-- .../maniphest/constants/base/ManiphestConstants.php | 4 ++-- .../editor/transaction/ManiphestTransactionEditor.php | 2 +- .../maniphest/replyhandler/ManiphestReplyHandler.php | 4 ++-- .../storage/auxiliary/ManiphestTaskAuxiliaryStorage.php | 4 ++-- src/applications/maniphest/storage/base/ManiphestDAO.php | 4 ++-- src/applications/maniphest/storage/task/ManiphestTask.php | 4 ++-- .../maniphest/storage/transaction/ManiphestTransaction.php | 4 ++-- .../maniphest/view/tasklist/ManiphestTaskListView.php | 2 +- .../view/tasksummary/ManiphestTaskSummaryView.php | 2 +- .../transactiondetail/ManiphestTransactionDetailView.php | 2 +- .../view/transactionlist/ManiphestTransactionListView.php | 2 +- .../PhabricatorMailImplementationAmazonSESAdapter.php | 4 ++-- .../PhabricatorMailImplementationPHPMailerLiteAdapter.php | 5 ++++- .../PhabricatorMailImplementationSendGridAdapter.php | 4 ++-- .../test/PhabricatorMailImplementationTestAdapter.php | 4 ++-- .../metamta/storage/mail/PhabricatorMetaMTAAttachment.php | 2 +- .../metamta/storage/mail/PhabricatorMetaMTAMail.php | 2 +- .../mail/__tests__/PhabricatorMetaMTAMailTestCase.php | 4 ++-- .../storage/mailinglist/PhabricatorMetaMTAMailingList.php | 4 ++-- .../receivedmail/PhabricatorMetaMTAReceivedMail.php | 2 +- .../owners/query/path/PhabricatorOwnerPathQuery.php | 4 ++-- .../owners/storage/owner/PhabricatorOwnersOwner.php | 4 ++-- .../owners/storage/package/PhabricatorOwnersPackage.php | 4 ++-- .../owners/storage/path/PhabricatorOwnersPath.php | 4 ++-- src/applications/paste/storage/paste/PhabricatorPaste.php | 4 ++-- src/applications/people/storage/log/PhabricatorUserLog.php | 2 +- .../storage/preferences/PhabricatorUserPreferences.php | 2 +- .../people/storage/profile/PhabricatorUserProfile.php | 4 ++-- src/applications/people/storage/user/PhabricatorUser.php | 2 +- .../storage/useroauthinfo/PhabricatorUserOAuthInfo.php | 4 ++-- .../people/storage/usersshkey/PhabricatorUserSSHKey.php | 2 +- src/applications/phid/handle/PhabricatorObjectHandle.php | 2 +- .../handle/const/status/PhabricatorObjectHandleStatus.php | 4 ++-- .../phid/handle/data/PhabricatorObjectHandleData.php | 2 +- .../selector/PhabricatorHandleObjectSelectorDataView.php | 4 ++-- src/applications/phid/storage/base/PhabricatorPHIDDAO.php | 4 ++-- src/applications/phid/storage/phid/PhabricatorPHID.php | 4 ++-- .../constants/action/PhrictionActionConstants.php | 4 ++-- .../phriction/storage/content/PhrictionContent.php | 2 +- .../phriction/storage/document/PhrictionDocument.php | 2 +- .../document/__tests__/PhrictionDocumentTestCase.php | 4 ++-- .../storage/affiliation/PhabricatorProjectAffiliation.php | 4 ++-- .../project/storage/base/PhabricatorProjectDAO.php | 4 ++-- .../project/storage/profile/PhabricatorProjectProfile.php | 4 ++-- .../project/storage/project/PhabricatorProject.php | 2 +- .../storage/transaction/PhabricatorProjectTransaction.php | 2 +- .../git/PhabricatorRepositoryGitCommitDiscoveryDaemon.php | 2 +- ...PhabricatorRepositoryMercurialCommitDiscoveryDaemon.php | 4 ++-- .../svn/PhabricatorRepositorySvnCommitDiscoveryDaemon.php | 4 ++-- .../committask/PhabricatorRepositoryCommitTaskDaemon.php | 4 ++-- ...abricatorRepositoryDefaultCommitMessageDetailParser.php | 3 +++ .../PhabricatorRepositoryArcanistProject.php | 4 ++-- .../repository/storage/base/PhabricatorRepositoryDAO.php | 4 ++-- .../storage/commit/PhabricatorRepositoryCommit.php | 2 +- .../storage/commitdata/PhabricatorRepositoryCommitData.php | 4 ++-- .../storage/repository/PhabricatorRepository.php | 2 +- .../storage/shortcut/PhabricatorRepositoryShortcut.php | 4 ++-- .../storage/symbol/PhabricatorRepositorySymbol.php | 5 ++--- .../PhabricatorRepositoryGitCommitChangeParserWorker.php | 2 +- ...bricatorRepositoryMercurialCommitChangeParserWorker.php | 4 ++-- .../PhabricatorRepositoryGitCommitMessageParserWorker.php | 2 +- ...ricatorRepositoryMercurialCommitMessageParserWorker.php | 2 +- .../PhabricatorRepositorySvnCommitMessageParserWorker.php | 4 ++-- .../herald/PhabricatorRepositoryCommitHeraldWorker.php | 2 +- .../owner/PhabricatorRepositoryCommitOwnersWorker.php | 2 +- .../differential/PhabricatorSearchDifferentialIndexer.php | 2 +- .../maniphest/PhabricatorSearchManiphestIndexer.php | 4 ++-- .../phriction/PhabricatorSearchPhrictionIndexer.php | 4 ++-- .../indexer/repository/PhabricatorSearchCommitIndexer.php | 2 +- .../index/indexer/user/PhabricatorSearchUserIndexer.php | 4 ++-- .../document/document/PhabricatorSearchDocument.php | 4 ++-- .../document/field/PhabricatorSearchDocumentField.php | 4 ++-- .../relationship/PhabricatorSearchDocumentRelationship.php | 4 ++-- .../slowvote/storage/base/PhabricatorSlowvoteDAO.php | 4 ++-- .../slowvote/storage/choice/PhabricatorSlowvoteChoice.php | 4 ++-- .../storage/comment/PhabricatorSlowvoteComment.php | 4 ++-- .../slowvote/storage/option/PhabricatorSlowvoteOption.php | 4 ++-- .../slowvote/storage/poll/PhabricatorSlowvotePoll.php | 4 ++-- .../uiexample/examples/client/JavelinViewExample.php | 4 ++-- .../examples/client/JavelinViewExampleServerView.php | 4 ++-- .../examples/listfilter/PhabricatorUIListFilterExample.php | 4 ++-- .../uiexample/examples/pager/PhabricatorUIPagerExample.php | 4 ++-- .../uiexample/examples/reactor/JavelinReactorExample.php | 4 ++-- .../storage/parsetree/PhabricatorXHPASTViewParseTree.php | 4 ++-- .../garbagecollector/PhabricatorGarbageCollectorDaemon.php | 4 ++-- .../PhabricatorIRCDifferentialNotificationHandler.php | 2 +- .../handler/objectname/PhabricatorIRCObjectNameHandler.php | 2 +- .../irc/handler/protocol/PhabricatorIRCProtocolHandler.php | 4 ++-- .../daemon/storage/event/PhabricatorDaemonLogEvent.php | 4 ++-- .../daemon/storage/log/PhabricatorDaemonLog.php | 4 ++-- .../cursor/iterator/PhabricatorTimelineIterator.php | 4 ++-- .../timeline/storage/base/PhabricatorTimelineDAO.php | 4 ++-- .../timeline/storage/cursor/PhabricatorTimelineCursor.php | 4 ++-- .../timeline/storage/event/PhabricatorTimelineEvent.php | 4 ++-- .../storage/eventdata/PhabricatorTimelineEventData.php | 4 ++-- .../daemon/workers/storage/task/PhabricatorWorkerTask.php | 4 ++-- .../workers/storage/taskdata/PhabricatorWorkerTaskData.php | 4 ++-- .../workers/taskmaster/PhabricatorTaskmasterDaemon.php | 4 ++-- .../goodfornothing/PhabricatorGoodForNothingWorker.php | 4 ++-- .../events/engine/PhabricatorEventEngine.php | 4 ++-- src/infrastructure/lint/engine/PhabricatorLintEngine.php | 4 ++-- .../hook/xhpastsymbolname/PhabricatorSymbolNameLinter.php | 4 ++-- .../lint/linter/javelin/PhabricatorJavelinLinter.php | 2 +- .../differential/PhabricatorRemarkupRuleDifferential.php | 4 ++-- .../diffusion/PhabricatorRemarkupRuleDiffusion.php | 4 ++-- .../embedobject/PhabricatorRemarkupRuleEmbedFile.php | 2 +- .../imagemacro/PhabricatorRemarkupRuleImageMacro.php | 2 +- .../maniphest/PhabricatorRemarkupRuleManiphest.php | 4 ++-- .../markuprule/mention/PhabricatorRemarkupRuleMention.php | 2 +- .../markuprule/paste/PhabricatorRemarkupRulePaste.php | 4 ++-- .../phriction/PhabricatorRemarkupRulePhriction.php | 4 ++-- .../proxyimage/PhabricatorRemarkupRuleProxyImage.php | 4 ++-- .../markuprule/youtube/PhabricatorRemarkupRuleYoutube.php | 4 ++-- src/infrastructure/setup/PhabricatorSetup.php | 2 +- .../testcase/__tests__/PhabricatorTrivialTestCase.php | 4 ++-- .../isolated/AphrontIsolatedDatabaseConnection.php | 3 ++- .../AphrontIsolatedDatabaseConnectionTestCase.php | 2 +- .../connection/mysql/AphrontMySQLDatabaseConnection.php | 2 +- .../accessdenied/AphrontQueryAccessDeniedException.php | 4 ++-- src/storage/exception/base/AphrontQueryException.php | 3 ++- .../connection/AphrontQueryConnectionException.php | 4 ++-- .../connectionlost/AphrontQueryConnectionLostException.php | 4 ++-- src/storage/exception/count/AphrontQueryCountException.php | 4 ++-- .../duplicatekey/AphrontQueryDuplicateKeyException.php | 4 ++-- .../objectmissing/AphrontQueryObjectMissingException.php | 4 ++-- .../exception/parameter/AphrontQueryParameterException.php | 4 ++-- .../recoverable/AphrontQueryRecoverableException.php | 7 +++++-- src/storage/lisk/dao/__tests__/LiskIsolationTestCase.php | 2 +- src/storage/lisk/dao/__tests__/LiskIsolationTestDAO.php | 4 ++-- .../lisk/dao/__tests__/LiskIsolationTestDAOException.php | 4 ++-- .../objectselector/PhabricatorObjectSelectorDialog.php | 4 ++-- src/view/control/table/AphrontTableView.php | 4 ++-- .../control/tokenizer/AphrontTokenizerTemplateView.php | 4 ++-- .../control/typeahead/AphrontTypeaheadTemplateView.php | 4 ++-- src/view/dialog/AphrontDialogView.php | 2 +- .../form/control/checkbox/AphrontFormCheckboxControl.php | 4 ++-- .../form/control/divider/AphrontFormDividerControl.php | 4 ++-- .../AphrontFormDragAndDropUploadControl.php | 4 ++-- src/view/form/control/file/AphrontFormFileControl.php | 4 ++-- src/view/form/control/markup/AphrontFormMarkupControl.php | 4 ++-- .../form/control/password/AphrontFormPasswordControl.php | 4 ++-- .../form/control/recaptcha/AphrontFormRecaptchaControl.php | 2 +- src/view/form/control/select/AphrontFormSelectControl.php | 2 +- src/view/form/control/static/AphrontFormStaticControl.php | 4 ++-- src/view/form/control/submit/AphrontFormSubmitControl.php | 4 ++-- src/view/form/control/text/AphrontFormTextControl.php | 4 ++-- .../form/control/textarea/AphrontFormTextAreaControl.php | 4 ++-- .../togglebuttons/AphrontFormToggleButtonsControl.php | 2 +- .../form/control/tokenizer/AphrontFormTokenizerControl.php | 2 +- src/view/javelin-view/AphrontJavelinView.php | 4 ++-- src/view/page/base/AphrontPageView.php | 2 +- src/view/page/standard/PhabricatorStandardPageView.php | 2 +- .../AphrontKeyboardShortcutsAvailableView.php | 4 ++-- 182 files changed, 318 insertions(+), 305 deletions(-) diff --git a/src/applications/base/storage/configuration/DatabaseConfigurationProvider.php b/src/applications/base/storage/configuration/DatabaseConfigurationProvider.php index cdc9652890..4e6f5837dd 100644 --- a/src/applications/base/storage/configuration/DatabaseConfigurationProvider.php +++ b/src/applications/base/storage/configuration/DatabaseConfigurationProvider.php @@ -1,7 +1,7 @@ runThreadIDHeadersWithConfiguration(true, true); diff --git a/src/applications/metamta/storage/mailinglist/PhabricatorMetaMTAMailingList.php b/src/applications/metamta/storage/mailinglist/PhabricatorMetaMTAMailingList.php index 49bbff7bfd..c429ccbd0d 100644 --- a/src/applications/metamta/storage/mailinglist/PhabricatorMetaMTAMailingList.php +++ b/src/applications/metamta/storage/mailinglist/PhabricatorMetaMTAMailingList.php @@ -1,7 +1,7 @@ getCommand()) { diff --git a/src/infrastructure/daemon/storage/event/PhabricatorDaemonLogEvent.php b/src/infrastructure/daemon/storage/event/PhabricatorDaemonLogEvent.php index 75e66c68f7..a02d61e9f4 100644 --- a/src/infrastructure/daemon/storage/event/PhabricatorDaemonLogEvent.php +++ b/src/infrastructure/daemon/storage/event/PhabricatorDaemonLogEvent.php @@ -1,7 +1,7 @@ getLeaseOwnershipName(); diff --git a/src/infrastructure/daemon/workers/worker/goodfornothing/PhabricatorGoodForNothingWorker.php b/src/infrastructure/daemon/workers/worker/goodfornothing/PhabricatorGoodForNothingWorker.php index 6315904aff..9d3e9341d5 100644 --- a/src/infrastructure/daemon/workers/worker/goodfornothing/PhabricatorGoodForNothingWorker.php +++ b/src/infrastructure/daemon/workers/worker/goodfornothing/PhabricatorGoodForNothingWorker.php @@ -1,7 +1,7 @@