archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Add "final" to (almost) everything else

Browse Source 
Summary: Last of the big final patches. Left a few debatable classes (12 out of about 400) that I'll deal with individually eventually.

Test Plan: Ran testEverythingImplemented.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T795

Differential Revision: https://secure.phabricator.com/D1881
This commit is contained in:
epriestley
2012-03-13 16:21:04 -07:00
parent 7c9057854b
commit d0af617818
182 changed files with 318 additions and 305 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/applications/project/storage/affiliation/PhabricatorProjectAffiliation.php
View File

@@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
* limitations under the License.
*/
class PhabricatorProjectAffiliation extends PhabricatorProjectDAO {
final class PhabricatorProjectAffiliation extends PhabricatorProjectDAO {
protected $projectPHID;
protected $userPHID;

4
src/applications/project/storage/base/PhabricatorProjectDAO.php
View File

@@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
* limitations under the License.
*/
class PhabricatorProjectDAO extends PhabricatorLiskDAO {
abstract class PhabricatorProjectDAO extends PhabricatorLiskDAO {
public function getApplicationName() {
return 'project';

4
src/applications/project/storage/profile/PhabricatorProjectProfile.php
View File

@@ -1,7 +1,7 @@
<?php
/*
* Copyright 2011 Facebook, Inc.
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,7 +16,7 @@
* limitations under the License.
*/
class PhabricatorProjectProfile extends PhabricatorProjectDAO {
final class PhabricatorProjectProfile extends PhabricatorProjectDAO {
protected $projectPHID;
protected $blurb;

2
src/applications/project/storage/project/PhabricatorProject.php
View File

@@ -16,7 +16,7 @@
* limitations under the License.
*/
class PhabricatorProject extends PhabricatorProjectDAO {
final class PhabricatorProject extends PhabricatorProjectDAO {
protected $name;
protected $phid;

2
src/applications/project/storage/transaction/PhabricatorProjectTransaction.php
View File

@@ -19,7 +19,7 @@
/**
* @group project
*/
class PhabricatorProjectTransaction extends PhabricatorProjectDAO {
final class PhabricatorProjectTransaction extends PhabricatorProjectDAO {
protected $projectID;
protected $authorPHID;