From d18ba3f0045c0bc4df349497b47205587a37a8a2 Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Fri, 1 Aug 2014 12:29:48 -0700
Subject: [PATCH] Fix tabs losing scroll position

Summary: we were missing an e.kill().  Fixes T5754.

Test Plan: looked at a file and selected different tabs - pre-patch vertical position lost and post patch vertical position preserved!

Reviewers: chad, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5754

Differential Revision: https://secure.phabricator.com/D10111
---
 resources/celerity/map.php                         | 14 +++++++-------
 .../rsrc/js/phui/behavior-phui-object-box-tabs.js  |  1 +
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 62217f5494..957f8a1026 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -491,7 +491,7 @@ return array(
     'rsrc/js/core/behavior-watch-anchor.js' => '06e05112',
     'rsrc/js/core/behavior-workflow.js' => '0a3f3021',
     'rsrc/js/core/phtize.js' => 'd254d646',
-    'rsrc/js/phui/behavior-phui-object-box-tabs.js' => 'a3e2244e',
+    'rsrc/js/phui/behavior-phui-object-box-tabs.js' => '2bfa2836',
     'rsrc/js/phui/behavior-phui-timeline-dropdown-menu.js' => '4d94d9c3',
     'rsrc/js/phuix/PHUIXActionListView.js' => 'b5c256b8',
     'rsrc/js/phuix/PHUIXActionView.js' => '6e8cefa4',
@@ -634,7 +634,7 @@ return array(
     'javelin-behavior-phame-post-preview' => 'be807912',
     'javelin-behavior-pholio-mock-edit' => '9c2623f4',
     'javelin-behavior-pholio-mock-view' => '152178f0',
-    'javelin-behavior-phui-object-box-tabs' => 'a3e2244e',
+    'javelin-behavior-phui-object-box-tabs' => '2bfa2836',
     'javelin-behavior-phui-timeline-dropdown-menu' => '4d94d9c3',
     'javelin-behavior-policy-control' => 'f3fef818',
     'javelin-behavior-policy-rule-editor' => 'fe9a552f',
@@ -1007,6 +1007,11 @@ return array(
       'javelin-workflow',
       'javelin-json',
     ),
+    '2bfa2836' => array(
+      'javelin-behavior',
+      'javelin-stratcom',
+      'javelin-dom',
+    ),
     '2cad29d1' => array(
       'javelin-install',
       'javelin-dom',
@@ -1473,11 +1478,6 @@ return array(
       'javelin-dom',
       'javelin-reactor-dom',
     ),
-    'a3e2244e' => array(
-      'javelin-behavior',
-      'javelin-stratcom',
-      'javelin-dom',
-    ),
     'a4ae61bf' => array(
       'javelin-install',
       'javelin-dom',
diff --git a/webroot/rsrc/js/phui/behavior-phui-object-box-tabs.js b/webroot/rsrc/js/phui/behavior-phui-object-box-tabs.js
index 4d9d0bf367..85cdf9345d 100644
--- a/webroot/rsrc/js/phui/behavior-phui-object-box-tabs.js
+++ b/webroot/rsrc/js/phui/behavior-phui-object-box-tabs.js
@@ -11,6 +11,7 @@ JX.behavior('phui-object-box-tabs', function() {
     'click',
     'phui-object-box-tab',
     function (e) {
+      e.kill();
       var key = e.getNodeData('phui-object-box-tab').tabKey;
       var map = e.getNodeData('phui-object-box').tabMap;
       var tab = e.getNode('phui-object-box-tab');