Move search, new room into thread column in Conpherence
Summary:
Moves search and new room out of crumb bar and into the thread column. This opens up space to add "Edit Room" into the crumbs area as an action link. Also removed 'widget-edit' pathways and javascript.
Fixes T8972
Test Plan:
Search, New, Edit rooms. Click different rooms, see correct URL each time.
{F1813226}
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T8972
Differential Revision: https://secure.phabricator.com/D16543
This commit is contained in:
@@ -51,8 +51,24 @@
|
||||
display: none;
|
||||
}
|
||||
|
||||
.conpherence-menu-pane.phabricator-side-menu .phui-list-item-type-label {
|
||||
.conpherence-menu-pane.phabricator-side-menu .room-list-href {
|
||||
padding: 10px 0 9px 8px;
|
||||
display: inline-block;
|
||||
text-transform: uppercase;
|
||||
color: {$darkgreytext};
|
||||
font-weight: bold;
|
||||
font-size: {$smallerfontsize};
|
||||
}
|
||||
|
||||
.conpherence-menu-pane.phabricator-side-menu .room-list-icons {
|
||||
display: inline-block;
|
||||
float: right;
|
||||
padding: 8px 0 5px;
|
||||
}
|
||||
|
||||
.conpherence-menu-pane .conpherence-room-list-header {
|
||||
clear: both;
|
||||
overflow: hidden;
|
||||
}
|
||||
|
||||
.conpherence-menu-pane .conpherence-room-list-header
|
||||
@@ -60,7 +76,7 @@
|
||||
font-weight: bold;
|
||||
float: right;
|
||||
text-transform: none;
|
||||
margin: 0px 8px 0px 0px;
|
||||
padding: 4px;
|
||||
}
|
||||
|
||||
.conpherence-menu-pane .conpherence-room-list-header
|
||||
|
||||
@@ -83,27 +83,11 @@ JX.behavior('conpherence-widget-pane', function(config) {
|
||||
|
||||
var handler;
|
||||
var href;
|
||||
if (widget == 'widgets-edit') {
|
||||
var threadManager = JX.ConpherenceThreadManager.getInstance();
|
||||
handler = function(e) {
|
||||
e.prevent();
|
||||
menu.close();
|
||||
threadManager.runUpdateWorkflowFromLink(
|
||||
e.getTarget(),
|
||||
{
|
||||
action : 'metadata',
|
||||
force_ajax : true,
|
||||
stage : 'submit'
|
||||
});
|
||||
};
|
||||
href = threadManager._getUpdateURI();
|
||||
} else {
|
||||
handler = JX.bind(null, function(widget, e) {
|
||||
toggleWidget({widget: widget});
|
||||
e.prevent();
|
||||
menu.close();
|
||||
}, widget);
|
||||
}
|
||||
handler = JX.bind(null, function(widget, e) {
|
||||
toggleWidget({widget: widget});
|
||||
e.prevent();
|
||||
menu.close();
|
||||
}, widget);
|
||||
var item = new JX.PHUIXActionView()
|
||||
.setIcon(widget_data.icon || 'none')
|
||||
.setName(widget_data.name)
|
||||
|
||||
Reference in New Issue
Block a user