diff --git a/conf/default.conf.php b/conf/default.conf.php index 8a3003eb43..62ce6b2b35 100644 --- a/conf/default.conf.php +++ b/conf/default.conf.php @@ -1,7 +1,7 @@ false, + // Shows an error callout if a page generated PHP errors, warnings or notices. + // This makes it harder to miss problems while developing Phabricator. + 'phabricator.show-error-callout' => false, + // When users write comments which have URIs, they'll be automaticaly linked // if the protocol appears in this set. This whitelist is primarily to prevent // security issues like javascript:// URIs. diff --git a/conf/development.conf.php b/conf/development.conf.php index 34edf822a1..963e6a88b2 100644 --- a/conf/development.conf.php +++ b/conf/development.conf.php @@ -1,7 +1,7 @@ true, - 'celerity.force-disk-reads' => true, - 'phabricator.show-stack-traces' => true, + 'darkconsole.enabled' => true, + 'celerity.force-disk-reads' => true, + 'phabricator.show-stack-traces' => true, + 'phabricator.show-error-callout' => true, ) + phabricator_read_config_file('default'); diff --git a/src/view/page/standard/PhabricatorStandardPageView.php b/src/view/page/standard/PhabricatorStandardPageView.php index a68baf7d92..b8859dbf28 100644 --- a/src/view/page/standard/PhabricatorStandardPageView.php +++ b/src/view/page/standard/PhabricatorStandardPageView.php @@ -1,7 +1,7 @@ '; } + $developer_warning = null; + if (PhabricatorEnv::getEnvConfig('phabricator.show-error-callout') && + DarkConsoleErrorLogPluginAPI::getErrors()) { + $developer_warning = + '