From d4f992d2ed09349755757d02bc887f80b464ad9b Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 6 Jan 2015 08:02:49 -0800 Subject: [PATCH] Continue after rejecting commits from a commit query Summary: Fixes T6880. If matching commits have no visible/loadable repository, we shouldn't keep going forward in the loop. Test Plan: Havne't built a repro locally yet so not 100% sure this fixes it. Reviewers: btrahan, mbishopim3, fabe Reviewed By: mbishopim3, fabe Subscribers: mbishopim3, epriestley Maniphest Tasks: T6880 Differential Revision: https://secure.phabricator.com/D11251 --- src/applications/diffusion/query/DiffusionCommitQuery.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/diffusion/query/DiffusionCommitQuery.php b/src/applications/diffusion/query/DiffusionCommitQuery.php index d63487c021..edd3484ec0 100644 --- a/src/applications/diffusion/query/DiffusionCommitQuery.php +++ b/src/applications/diffusion/query/DiffusionCommitQuery.php @@ -192,6 +192,7 @@ final class DiffusionCommitQuery $commit->attachRepository($repo); } else { unset($commits[$key]); + continue; } // Build the identifierMap