From d5e7cd5590e973c1fd0b45f899b1d7330a444ee2 Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Tue, 9 Dec 2014 11:29:21 -0800 Subject: [PATCH] Conpherence - fix add participant / remove participant form Summary: Ref T6713. We were dropping latest transaction ID. This should fix the "easy" part of T6713. Test Plan: tried to add participants and it worked! (removing participants only allows yourself, but that worked too.) Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6713 Differential Revision: https://secure.phabricator.com/D10952 --- .../controller/ConpherenceUpdateController.php | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/applications/conpherence/controller/ConpherenceUpdateController.php b/src/applications/conpherence/controller/ConpherenceUpdateController.php index 847dc26790..4ed523bef4 100644 --- a/src/applications/conpherence/controller/ConpherenceUpdateController.php +++ b/src/applications/conpherence/controller/ConpherenceUpdateController.php @@ -212,6 +212,9 @@ final class ConpherenceUpdateController return id(new AphrontDialogView()) ->setTitle(pht('Add Participants')) ->addHiddenInput('action', 'add_person') + ->addHiddenInput( + 'latest_transaction_id', + $request->getInt('latest_transaction_id')) ->appendChild($form); } @@ -241,8 +244,11 @@ final class ConpherenceUpdateController return id(new AphrontDialogView()) ->setTitle(pht('Remove Participants')) ->addHiddenInput('action', 'remove_person') - ->addHiddenInput('__continue__', true) ->addHiddenInput('remove_person', $remove_person) + ->addHiddenInput( + 'latest_transaction_id', + $request->getInt('latest_transaction_id')) + ->addHiddenInput('__continue__', true) ->appendChild($body); } @@ -250,6 +256,7 @@ final class ConpherenceUpdateController ConpherenceThread $conpherence, $error_view) { + $request = $this->getRequest(); $form = id(new PHUIFormLayoutView()) ->appendChild($error_view) ->appendChild( @@ -262,6 +269,9 @@ final class ConpherenceUpdateController return id(new AphrontDialogView()) ->setTitle(pht('Update Conpherence')) ->addHiddenInput('action', 'metadata') + ->addHiddenInput( + 'latest_transaction_id', + $request->getInt('latest_transaction_id')) ->addHiddenInput('__continue__', true) ->appendChild($form); }