From d76175285e96252cb3962d6a5a3cde434ed2a80d Mon Sep 17 00:00:00 2001 From: Chad Little Date: Sun, 13 Mar 2016 16:01:05 -0700 Subject: [PATCH] Update Diff view page to new layout Summary: Converts Diff View, single column though. Test Plan: Upload a new diff, review page. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15470 --- .../DifferentialDiffViewController.php | 27 ++++++++++++++----- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/src/applications/differential/controller/DifferentialDiffViewController.php b/src/applications/differential/controller/DifferentialDiffViewController.php index 716a183b5b..b2c497f6ac 100644 --- a/src/applications/differential/controller/DifferentialDiffViewController.php +++ b/src/applications/differential/controller/DifferentialDiffViewController.php @@ -126,27 +126,40 @@ final class DifferentialDiffViewController extends DifferentialController { ->setRenderingReferences($refs) ->setStandaloneURI('/differential/changeset/') ->setDiff($diff) + ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setTitle(pht('Diff %d', $diff->getID())) ->setUser($request->getUser()); + $title = pht('Diff %d', $diff->getID()); $crumbs = $this->buildApplicationCrumbs(); - $crumbs->addTextCrumb(pht('Diff %d', $diff->getID())); + $crumbs->addTextCrumb($title); + $crumbs->setBorder(true); + + $header = id(new PHUIHeaderView()) + ->setHeader($title); $prop_box = id(new PHUIObjectBoxView()) ->setHeader($property_head) + ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->addPropertyList($property_view) ->setForm($form); - return $this->buildApplicationPage( - array( - $crumbs, + $view = id(new PHUITwoColumnView()) + ->setHeader($header) + ->setMainColumn(array( + + )) + ->setFooter(array( $prop_box, $table_of_contents, $details, - ), - array( - 'title' => pht('Diff View'), )); + + $page = $this->newPage() + ->setTitle(pht('Diff View')) + ->setCrumbs($crumbs) + ->appendChild($view); + return $page; } private function loadSelectableRevisions(