Prepare for db-driven auth configuration by making proviers operate in dual modes

Summary:
Ref T1536. This sets us for the "Config -> Database" migration. Basically:

  - If stuff is defined in the database, respect the database stuff (no installs have anything defined yet since they can't reach the interfaces/code).
  - Otherwise, respect the config stuff (all installs currently do this).

Test Plan: Saw database stuff respected when database stuff was defined; saw config stuff respected otherwise.

Reviewers: chad, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1536

Differential Revision: https://secure.phabricator.com/D6240

src/applications/auth/controller/config/PhabricatorAuthEditController.php

@@ -60,12 +60,8 @@ final class PhabricatorAuthEditController
         throw new Exception("This provider is already configured!");
       }
 
-      $config = id(new PhabricatorAuthProviderConfig())
-        ->setProviderClass(get_class($provider))
-        ->setShouldAllowLogin(1)
-        ->setShouldAllowRegistration(1)
-        ->setShouldAllowLink(1)
-        ->setShouldAllowUnlink(1);
+      $config = $provider->getDefaultProviderConfig();
+      $provider->attachProviderConfig($config);
 
       $is_new = true;
     }
@@ -87,11 +83,6 @@ final class PhabricatorAuthEditController
 
       if (!$errors) {
         if ($is_new) {
-          $xactions[] = id(new PhabricatorAuthProviderConfigTransaction())
-            ->setTransactionType(
-              PhabricatorAuthProviderConfigTransaction::TYPE_ENABLE)
-            ->setNewValue(1);
-
           $config->setProviderType($provider->getProviderType());
           $config->setProviderDomain($provider->getProviderDomain());
         }
@@ -177,7 +168,11 @@ final class PhabricatorAuthEditController
 
     $status_tag = id(new PhabricatorTagView())
       ->setType(PhabricatorTagView::TYPE_STATE);
-    if ($config->getIsEnabled()) {
+    if ($is_new) {
+      $status_tag
+        ->setName(pht('New Provider'))
+        ->setBackgroundColor('blue');
+    } else if ($config->getIsEnabled()) {
       $status_tag
         ->setName(pht('Enabled'))
         ->setBackgroundColor('green');