diff --git a/src/applications/differential/editor/comment/DifferentialCommentEditor.php b/src/applications/differential/editor/comment/DifferentialCommentEditor.php index ab76ace9a2..b1f21c1262 100644 --- a/src/applications/differential/editor/comment/DifferentialCommentEditor.php +++ b/src/applications/differential/editor/comment/DifferentialCommentEditor.php @@ -452,6 +452,9 @@ final class DifferentialCommentEditor { $revision->setLastReviewerPHID($actor_phid); } + // TODO: Call beginReadLocking() prior to loading the revision. + $revision->openTransaction(); + // Always save the revision (even if we didn't actually change any of its // properties) so that it jumps to the top of the revision list when sorted // by "updated". Notably, this allows "ping" comments to push it to the @@ -522,6 +525,8 @@ final class DifferentialCommentEditor { } } + $revision->saveTransaction(); + $phids = array($this->actorPHID); $handles = id(new PhabricatorObjectHandleData($phids)) ->loadHandles();