From d92f303e0cdbd78f62fe7f0adfa494068ccd08b1 Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 30 Jun 2011 13:58:28 -0700 Subject: [PATCH] Use authoritative user identity for revision author Summary: We added a proper way to get the authoritative user a while ago, this method just never got switched to use it. Test Plan: Created a revision locally, was recognized as the revision author. Reviewed By: jungejason Reviewers: gc3, jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 566 --- .../ConduitAPI_differential_createrevision_Method.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/applications/conduit/method/differential/createrevision/ConduitAPI_differential_createrevision_Method.php b/src/applications/conduit/method/differential/createrevision/ConduitAPI_differential_createrevision_Method.php index f9f246448b..29a9cf4f5c 100644 --- a/src/applications/conduit/method/differential/createrevision/ConduitAPI_differential_createrevision_Method.php +++ b/src/applications/conduit/method/differential/createrevision/ConduitAPI_differential_createrevision_Method.php @@ -26,7 +26,6 @@ class ConduitAPI_differential_createrevision_Method extends ConduitAPIMethod { return array( 'diffid' => 'required diffid', 'fields' => 'required dict', - 'user' => 'required guid', ); } @@ -51,7 +50,7 @@ class ConduitAPI_differential_createrevision_Method extends ConduitAPIMethod { $revision = DifferentialRevisionEditor::newRevisionFromConduitWithDiff( $fields, $diff, - $request->getValue('user')); // TODO: Should be authoritative + $request->getUser()->getPHID()); return array( 'revisionid' => $revision->getID(),