From d9aa9eec785748acdb80d76b12dc4b5b29adad58 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 23 Sep 2013 14:30:20 -0700
Subject: [PATCH] Route Maniphest email through the transaction core

Summary: Ref T2217. Build transaction details using transaction code.

Test Plan: See screenshot.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2217

Differential Revision: https://secure.phabricator.com/D7074
---
 .../editor/ManiphestTransactionEditor.php     | 23 +++++++++++++++----
 .../storage/ManiphestTransaction.php          |  2 ++
 2 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/src/applications/maniphest/editor/ManiphestTransactionEditor.php b/src/applications/maniphest/editor/ManiphestTransactionEditor.php
index 35651c6a78..b0f5bad0e3 100644
--- a/src/applications/maniphest/editor/ManiphestTransactionEditor.php
+++ b/src/applications/maniphest/editor/ManiphestTransactionEditor.php
@@ -250,11 +250,24 @@ final class ManiphestTransactionEditor extends PhabricatorEditor {
       ->withPHIDs($phids)
       ->execute();
 
-    $view = new ManiphestTransactionDetailView();
-    $view->setTransactionGroup($transactions);
-    $view->setHandles($handles);
-    $view->setAuxiliaryFields($this->auxiliaryFields);
-    list($action, $main_body) = $view->renderForEmail($with_date = false);
+    $main_body = array();
+    foreach ($transactions as $transaction) {
+      $main_body[] = id(clone $transaction->getModernTransaction())
+        ->setHandles($handles)
+        ->setRenderingTarget('text')
+        ->getTitle();
+    }
+
+    foreach ($transactions as $transaction) {
+      if ($transaction->getComments()) {
+        $main_body[] = null;
+        $main_body[] = $transaction->getComments();
+      }
+    }
+
+    $main_body = implode("\n", $main_body);
+
+    $action = head($transactions)->getModernTransaction()->getActionName();
 
     $is_create = $this->isCreate($transactions);
 
diff --git a/src/applications/maniphest/storage/ManiphestTransaction.php b/src/applications/maniphest/storage/ManiphestTransaction.php
index 363b476b83..cb0aa64cd1 100644
--- a/src/applications/maniphest/storage/ManiphestTransaction.php
+++ b/src/applications/maniphest/storage/ManiphestTransaction.php
@@ -52,6 +52,8 @@ final class ManiphestTransaction
           ->setCommentPHID($comment->getPHID())
           ->save();
 
+        $this->proxy->attachComment($comment);
+
         $this->pendingComment = null;
       }
     $this->proxy->saveTransaction();