archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Explicitly set URL parameter separator for external URLs

Browse Source 
Summary:
PHP has this crazy [[ http://php.net/arg_separator.output | arg_separator.output ]] INI setting which allows setting different string for URL parameters separator instead of `&` (e.g. in `?a=1&b=2`).

Don't use it for external URLs.

Test Plan: Log in through OAuth.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2284
This commit is contained in:
vrana
2012-04-19 14:22:59 -07:00
parent 9fd3958567
commit d9ce80aa17
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/auth/controller/oauth/PhabricatorOAuthLoginController.php
View File

@@ -255,7 +255,7 @@ final class PhabricatorOAuthLoginController
'code' => $code,
) + $provider->getExtraTokenParameters();
$post_data = http_build_query($query_data);
$post_data = http_build_query($query_data, '', '&');
$post_length = strlen($post_data);
$stream_context = stream_context_create(