From db2fef4c87b588e1cf971e83adf131d25ad04322 Mon Sep 17 00:00:00 2001
From: vrana <jakubv@fb.com>
Date: Mon, 9 Apr 2012 01:07:12 -0700
Subject: [PATCH] Don't display "Foul Magicks" in Maniphest

Summary:
There was a typo:
`PHID-!!!!-NO_PROJECT` instead of
`PHID-!!!!-NO-PROJECT`

Also use `<em>` to differentiate from project named "(No Project)".

Test Plan:
/maniphest/report/project/
Click on (No Project).

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Differential Revision: https://secure.phabricator.com/D2167
---
 .../controller/report/ManiphestReportController.php  | 12 ++++++------
 .../maniphest/controller/report/__init__.php         |  1 +
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/applications/maniphest/controller/report/ManiphestReportController.php b/src/applications/maniphest/controller/report/ManiphestReportController.php
index 84fcd95dbc..91a95a96e4 100644
--- a/src/applications/maniphest/controller/report/ManiphestReportController.php
+++ b/src/applications/maniphest/controller/report/ManiphestReportController.php
@@ -424,15 +424,15 @@ final class ManiphestReportController extends ManiphestController {
         $leftover_closed = idx($result_closed, '', array());
         unset($result_closed['']);
 
+        $base_link = '/maniphest/?users=';
         $leftover_name = phutil_render_tag(
           'a',
           array(
-            'href' => '/maniphest/?users=PHID-!!!!-UP-FOR-GRABS',
+            'href' => $base_link.ManiphestTaskOwner::OWNER_UP_FOR_GRABS,
           ),
-          '(Up For Grabs)');
+          '<em>(Up For Grabs)</em>');
         $col_header = 'User';
         $header = 'Open Tasks by User and Priority ('.$date.')';
-        $base_link = '/maniphest/?users=';
         break;
       case 'project':
         $result = array();
@@ -461,15 +461,15 @@ final class ManiphestReportController extends ManiphestController {
           }
         }
 
+        $base_link = '/maniphest/view/all/?projects=';
         $leftover_name = phutil_render_tag(
           'a',
           array(
-            'href' => '/maniphest/view/all/?projects=PHID-!!!!-NO_PROJECT',
+            'href' => $base_link.ManiphestTaskOwner::PROJECT_NO_PROJECT,
           ),
-          '(No Project)');
+          '<em>(No Project)</em>');
         $col_header = 'Project';
         $header = 'Open Tasks by Project and Priority ('.$date.')';
-        $base_link = '/maniphest/view/all/?projects=';
         break;
     }
 
diff --git a/src/applications/maniphest/controller/report/__init__.php b/src/applications/maniphest/controller/report/__init__.php
index 3ff3109a4f..f07f5c347a 100644
--- a/src/applications/maniphest/controller/report/__init__.php
+++ b/src/applications/maniphest/controller/report/__init__.php
@@ -8,6 +8,7 @@
 
 phutil_require_module('phabricator', 'aphront/response/404');
 phutil_require_module('phabricator', 'aphront/response/redirect');
+phutil_require_module('phabricator', 'applications/maniphest/constants/owner');
 phutil_require_module('phabricator', 'applications/maniphest/constants/priority');
 phutil_require_module('phabricator', 'applications/maniphest/constants/status');
 phutil_require_module('phabricator', 'applications/maniphest/constants/transactiontype');