From db35bbcbcc71a4c35ce5758ae4f740403cebd35c Mon Sep 17 00:00:00 2001 From: Chad Little Date: Mon, 4 Mar 2013 15:01:53 -0800 Subject: [PATCH] Shorten titles in Pholio Summary: Shortens the titles to 24 characters. Will likely make the boards bigger than 240px at some point. Test Plan: Tested normal phrases as well as MMMMMMMms. M's will break, but only slightly. Felt it was a fair tradeoff? Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2660 Differential Revision: https://secure.phabricator.com/D5215 --- src/__celerity_resource_map__.php | 2 +- .../pholio/controller/PholioMockListController.php | 1 - webroot/rsrc/css/layout/phabricator-pinboard-view.css | 7 +++---- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index 82f7c62406..7b7038b54b 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -2880,7 +2880,7 @@ celerity_register_resource_map(array( ), 'phabricator-pinboard-view-css' => array( - 'uri' => '/res/b5a7de33/rsrc/css/layout/phabricator-pinboard-view.css', + 'uri' => '/res/c6af8d76/rsrc/css/layout/phabricator-pinboard-view.css', 'type' => 'css', 'requires' => array( diff --git a/src/applications/pholio/controller/PholioMockListController.php b/src/applications/pholio/controller/PholioMockListController.php index 62c67b8609..70d8733ec2 100644 --- a/src/applications/pholio/controller/PholioMockListController.php +++ b/src/applications/pholio/controller/PholioMockListController.php @@ -66,7 +66,6 @@ final class PholioMockListController extends PholioController { 'div', array(), pht('Created on %s', $datetime))); - $board->addItem($item); } diff --git a/webroot/rsrc/css/layout/phabricator-pinboard-view.css b/webroot/rsrc/css/layout/phabricator-pinboard-view.css index feea7598bd..f13979f259 100644 --- a/webroot/rsrc/css/layout/phabricator-pinboard-view.css +++ b/webroot/rsrc/css/layout/phabricator-pinboard-view.css @@ -14,8 +14,8 @@ background: #ffffff; border-radius: 3px; - display: block; float: left; + width: 240px; box-shadow: 0 1px 3px rgba(0, 0, 0, 0.15); text-align: left; } @@ -29,9 +29,6 @@ .device-phone .phabricator-pinboard-item-view { float: none; margin: 0 auto 10px; - - /* NOTE: This needs to be changed if we use images other than 160px wide. */ - width: 240px; } .phabricator-pinboard-item-header { @@ -42,6 +39,8 @@ border-top-left-radius: 3px; border-top-right-radius: 3px; border-bottom: 1px solid #d5d9df; + white-space: nowrap; + overflow: hidden; } .phabricator-pinboard-item-header a {