From dc9aaa0fc2bf41ed01e4beeeca98c442c486fe8e Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 25 Feb 2019 12:41:57 -0800 Subject: [PATCH] Fix a stray "%Q" warning when hiding/showing inline comments Summary: See PHI1095. Test Plan: Viewed a revision, toggled hide/show on inline comments. Before: warning in logs; after: smooth sailing. Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D20212 --- .../controller/DifferentialInlineCommentEditController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/differential/controller/DifferentialInlineCommentEditController.php b/src/applications/differential/controller/DifferentialInlineCommentEditController.php index 9741cc93ee..1de156a9b7 100644 --- a/src/applications/differential/controller/DifferentialInlineCommentEditController.php +++ b/src/applications/differential/controller/DifferentialInlineCommentEditController.php @@ -204,9 +204,9 @@ final class DifferentialInlineCommentEditController queryfx( $conn_w, - 'INSERT IGNORE INTO %T (userPHID, commentID) VALUES %Q', + 'INSERT IGNORE INTO %T (userPHID, commentID) VALUES %LQ', $table->getTableName(), - implode(', ', $sql)); + $sql); } protected function showComments(array $ids) {