From dd3f05ec2503cd92deb005639209b4b55c927b10 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 11 Sep 2017 16:30:35 -0700
Subject: [PATCH] Remove "Name Contains" query constraint from Diffusion for
 Repositories

Summary:
Ref T12819. Obsoleted by the Ferret engine "Query" field.

This is a compatibility break, I'll note it in the changelog.

Test Plan: Searched for repositories by name with "Query" instead of "Name Contains".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12819

Differential Revision: https://secure.phabricator.com/D18588
---
 .../repository/query/PhabricatorRepositoryQuery.php | 13 -------------
 .../query/PhabricatorRepositorySearchEngine.php     |  7 -------
 2 files changed, 20 deletions(-)

diff --git a/src/applications/repository/query/PhabricatorRepositoryQuery.php b/src/applications/repository/query/PhabricatorRepositoryQuery.php
index 85b2ea0f0d..ffa9fa1b59 100644
--- a/src/applications/repository/query/PhabricatorRepositoryQuery.php
+++ b/src/applications/repository/query/PhabricatorRepositoryQuery.php
@@ -8,7 +8,6 @@ final class PhabricatorRepositoryQuery
   private $callsigns;
   private $types;
   private $uuids;
-  private $nameContains;
   private $uris;
   private $datasourceQuery;
   private $slugs;
@@ -116,11 +115,6 @@ final class PhabricatorRepositoryQuery
     return $this;
   }
 
-  public function withNameContains($contains) {
-    $this->nameContains = $contains;
-    return $this;
-  }
-
   public function withURIs(array $uris) {
     $this->uris = $uris;
     return $this;
@@ -661,13 +655,6 @@ final class PhabricatorRepositoryQuery
         $this->uuids);
     }
 
-    if (strlen($this->nameContains)) {
-      $where[] = qsprintf(
-        $conn,
-        'r.name LIKE %~',
-        $this->nameContains);
-    }
-
     if (strlen($this->datasourceQuery)) {
       // This handles having "rP" match callsigns starting with "P...".
       $query = trim($this->datasourceQuery);
diff --git a/src/applications/repository/query/PhabricatorRepositorySearchEngine.php b/src/applications/repository/query/PhabricatorRepositorySearchEngine.php
index f321a112d9..5cd88183e1 100644
--- a/src/applications/repository/query/PhabricatorRepositorySearchEngine.php
+++ b/src/applications/repository/query/PhabricatorRepositorySearchEngine.php
@@ -24,9 +24,6 @@ final class PhabricatorRepositorySearchEngine
       id(new PhabricatorSearchStringListField())
         ->setLabel(pht('Callsigns'))
         ->setKey('callsigns'),
-      id(new PhabricatorSearchTextField())
-        ->setLabel(pht('Name Contains'))
-        ->setKey('name'),
       id(new PhabricatorSearchSelectField())
         ->setLabel(pht('Status'))
         ->setKey('status')
@@ -72,10 +69,6 @@ final class PhabricatorRepositorySearchEngine
       $query->withTypes($map['types']);
     }
 
-    if (strlen($map['name'])) {
-      $query->withNameContains($map['name']);
-    }
-
     if ($map['uris']) {
       $query->withURIs($map['uris']);
     }