From df272dfa266bbf7de8d5b5520ec41e9040211ed6 Mon Sep 17 00:00:00 2001 From: epriestley Date: Sat, 16 Jan 2016 12:24:29 -0800 Subject: [PATCH] Allow autocomplete to activate after ">", ":" or "!" Summary: Ref T10163. This allows activation in blockquotes or after `NOTE:`, for consistency. Test Plan: Typed `>@dog`, etc., got autocomplete. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10163 Differential Revision: https://secure.phabricator.com/D15035 --- resources/celerity/map.php | 16 ++++++++-------- webroot/rsrc/js/phuix/PHUIXAutocomplete.js | 3 +++ 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index dafe3e3166..6d064736a6 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -507,7 +507,7 @@ return array( 'rsrc/js/phui/behavior-phui-object-box-tabs.js' => '2bfa2836', 'rsrc/js/phuix/PHUIXActionListView.js' => 'b5c256b8', 'rsrc/js/phuix/PHUIXActionView.js' => '8cf6d262', - 'rsrc/js/phuix/PHUIXAutocomplete.js' => '3dfff01f', + 'rsrc/js/phuix/PHUIXAutocomplete.js' => '3601bdd1', 'rsrc/js/phuix/PHUIXDropdownMenu.js' => 'bd4c8dca', 'rsrc/js/phuix/PHUIXFormControl.js' => '8fba1997', 'rsrc/js/phuix/PHUIXIconView.js' => 'bff6884b', @@ -836,7 +836,7 @@ return array( 'phui-workpanel-view-css' => 'adec7699', 'phuix-action-list-view' => 'b5c256b8', 'phuix-action-view' => '8cf6d262', - 'phuix-autocomplete' => '3dfff01f', + 'phuix-autocomplete' => '3601bdd1', 'phuix-dropdown-menu' => 'bd4c8dca', 'phuix-form-control-view' => '8fba1997', 'phuix-icon-view' => 'bff6884b', @@ -1064,6 +1064,12 @@ return array( 'javelin-vector', 'phuix-autocomplete', ), + '3601bdd1' => array( + 'javelin-install', + 'javelin-dom', + 'phuix-icon-view', + 'phabricator-prefab', + ), '3ab51e2c' => array( 'javelin-behavior', 'javelin-behavior-device', @@ -1080,12 +1086,6 @@ return array( 'javelin-util', 'javelin-uri', ), - '3dfff01f' => array( - 'javelin-install', - 'javelin-dom', - 'phuix-icon-view', - 'phabricator-prefab', - ), '3ee3408b' => array( 'javelin-behavior', 'javelin-behavior-device', diff --git a/webroot/rsrc/js/phuix/PHUIXAutocomplete.js b/webroot/rsrc/js/phuix/PHUIXAutocomplete.js index 7df865138b..e35f31ce98 100644 --- a/webroot/rsrc/js/phuix/PHUIXAutocomplete.js +++ b/webroot/rsrc/js/phuix/PHUIXAutocomplete.js @@ -111,6 +111,9 @@ JX.install('PHUIXAutocomplete', { case '-': // Might be an unnumbered list. case '.': // Might be a numbered list. case '|': // Might be a table cell. + case '>': // Might be a blockquote. + case '!': // Might be a blockquote attribution line. + case ':': // Might be a "NOTE:". // We'll let these autocomplete. break; default: