From df85cd83d1568c4903f4af8a0ca3bc97b64678a2 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 27 Nov 2013 21:03:00 -0800 Subject: [PATCH] Put PATH in $_ENV after we adjust it so ExecFuture/etc pick it up Summary: The change to setEnv() means this may not propagate correctly in some cases. See IRC. Auditors: btrahan --- src/infrastructure/env/PhabricatorEnv.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/infrastructure/env/PhabricatorEnv.php b/src/infrastructure/env/PhabricatorEnv.php index 44a43e62ec..f4882c0be1 100644 --- a/src/infrastructure/env/PhabricatorEnv.php +++ b/src/infrastructure/env/PhabricatorEnv.php @@ -108,6 +108,10 @@ final class PhabricatorEnv { } putenv('PATH='.$env_path); + // Write this back into $_ENV, too, so ExecFuture picks it up when creating + // subprocess environments. + $_ENV['PATH'] = $env_path; + PhabricatorEventEngine::initialize(); $translation = PhabricatorEnv::newObjectFromConfig('translation.provider');