Separate Phriction style into PHUIDocumentView

Summary:
Ref T988. Fixes T3150. I want to use this element in Diviner, so separate it from Phriction.

This makes no changes to the actual display except for fixing {T3150} by adding `overflow: hidden;`.

Test Plan: Viewed Phriction documents in mobile and desktop views.

Reviewers: chad, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T988, T3150

Differential Revision: https://secure.phabricator.com/D6101

src/__celerity_resource_map__.php

@@ -3636,7 +3636,7 @@ celerity_register_resource_map(array(
   ),
   'phriction-document-css' =>
   array(
-    'uri' => '/res/14e08350/rsrc/css/application/phriction/phriction-document-css.css',
+    'uri' => '/res/97a9ef40/rsrc/css/application/phriction/phriction-document-css.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -3652,6 +3652,15 @@ celerity_register_resource_map(array(
     ),
     'disk' => '/rsrc/css/phui/phui-box.css',
   ),
+  'phui-document-view-css' =>
+  array(
+    'uri' => '/res/ca376da1/rsrc/css/phui/phui-document.css',
+    'type' => 'css',
+    'requires' =>
+    array(
+    ),
+    'disk' => '/rsrc/css/phui/phui-document.css',
+  ),
   'phui-feed-story-css' =>
   array(
     'uri' => '/res/253ac568/rsrc/css/phui/phui-feed-story.css',

src/__phutil_library_map__.php

@@ -682,6 +682,7 @@ phutil_register_library_map(array(
     'PHUI' => 'view/phui/PHUI.php',
     'PHUIBoxExample' => 'applications/uiexample/examples/PHUIBoxExample.php',
     'PHUIBoxView' => 'view/phui/PHUIBoxView.php',
+    'PHUIDocumentView' => 'view/phui/PHUIDocumentView.php',
     'PHUIFeedStoryExample' => 'applications/uiexample/examples/PHUIFeedStoryExample.php',
     'PHUIFeedStoryView' => 'view/phui/PHUIFeedStoryView.php',
     'PHUIFormDividerControl' => 'view/form/control/PHUIFormDividerControl.php',
@@ -2494,6 +2495,7 @@ phutil_register_library_map(array(
     'OwnersPackageReplyHandler' => 'PhabricatorMailReplyHandler',
     'PHUIBoxExample' => 'PhabricatorUIExample',
     'PHUIBoxView' => 'AphrontTagView',
+    'PHUIDocumentView' => 'AphrontTagView',
     'PHUIFeedStoryExample' => 'PhabricatorUIExample',
     'PHUIFeedStoryView' => 'AphrontView',
     'PHUIFormDividerControl' => 'AphrontFormControl',

src/applications/phriction/controller/PhrictionDocumentController.php

@@ -163,18 +163,16 @@ final class PhrictionDocumentController
     $header = id(new PhabricatorHeaderView())
       ->setHeader($page_title);
 
-    $page_content = hsprintf(
-      '<div class="phriction-wrap">
-        <div class="phriction-content">
-          %s%s%s%s%s
-        </div>
-        <div class="phriction-fake-space"></div>
-      </div>',
-      $header,
-      $actions,
-      $properties,
-      $move_notice,
-      $core_content);
+    $page_content = id(new PHUIDocumentView())
+      ->setOffset(true)
+      ->appendChild(
+        array(
+          $header,
+          $actions,
+          $properties,
+          $move_notice,
+          $core_content,
+        ));
 
     $core_page = phutil_tag(
       'div',
@@ -420,15 +418,24 @@ final class PhrictionDocumentController
       $list[] = phutil_tag('li', array(), pht('More...'));
     }
 
-    return hsprintf(
-      '<div class="phriction-wrap">
-        <div class="phriction-children">
-        <div class="phriction-children-header">%s</div>
-        %s
-        </div>
-      </div>',
-      pht('Document Hierarchy'),
-      phutil_tag('ul', array(), $list));
+    $content = array(
+      phutil_tag(
+        'div',
+        array(
+          'class' => 'phriction-children-header',
+        ),
+        pht('Document Hierarchy')),
+      phutil_tag(
+        'div',
+        array(
+          'class' => 'phriction-children',
+        ),
+        phutil_tag('ul', array(), $list)),
+    );
+
+    return id(new PHUIDocumentView())
+      ->setOffset(true)
+      ->appendChild($content);
   }
 
   private function renderChildDocumentLink(array $info) {

src/view/phui/PHUIDocumentView.php

@@ -0,0 +1,40 @@
+<?php
+
+final class PHUIDocumentView extends AphrontTagView {
+
+  private $offset;
+
+  public function setOffset($offset) {
+    $this->offset = $offset;
+    return $this;
+  }
+
+  public function getTagAttributes() {
+    $classes = array();
+
+    if ($this->offset) {
+      $classes[] = 'phui-document-offset';
+    };
+
+    return array(
+      'class' => $classes,
+    );
+  }
+
+  public function getTagContent() {
+    require_celerity_resource('phui-document-view-css');
+
+    return phutil_tag(
+      'div',
+      array(
+        'class' => 'phui-document-view',
+      ),
+      phutil_tag(
+        'div',
+        array(
+          'class' => 'phui-document-content',
+        ),
+        $this->renderChildren()));
+  }
+
+}