Switched Main Directory Jump Panel to a Jump List Filter

Summary:
Sorry, I'm bad with puns

{F38258}

vs

{F38259}

It was a tough decision. We went with the latter. See chatlog today.

Test Plan: See screens

Reviewers: epriestley, chad, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5522
This commit is contained in:
Anh Nhan Nguyen
2013-04-01 08:33:14 -07:00
committed by epriestley
parent 2334f63c2c
commit e34aa8add7
3 changed files with 68 additions and 52 deletions

View File

@@ -338,22 +338,28 @@ final class PhabricatorDirectoryMainController
'it. See %s or type <tt>help</tt>.',
$doc_link));
$form = phabricator_form(
$user,
array(
'action' => '/jump/',
'method' => 'POST',
'class' => 'phabricator-jump-nav-form',
),
array(
$jump_input,
$jump_caption,
));
$panel = new AphrontPanelView();
$panel->setHeader('Jump Nav');
$panel->appendChild(
phabricator_form(
$user,
array(
'action' => '/jump/',
'method' => 'POST',
'class' => 'phabricator-jump-nav-form',
),
array(
$jump_input,
$jump_caption,
)));
$panel->setNoBackground();
// $panel->appendChild();
return $panel;
$list_filter = new AphrontListFilterView();
$list_filter->appendChild(phutil_tag('h1', array(), 'Jump Nav'));
$list_filter->appendChild($form);
return $list_filter;
}
private function renderMiniPanel($title, $body) {