From e47f85cd98b869fe97b3e6143f5de0670039d6da Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 26 Jul 2017 10:09:36 -0700 Subject: [PATCH] In Differential, filter repository operations to just "Land" operations again Summary: Reverts D18276. See PHI18 for discussion. The additional rules here (roughly, "only show the first successful operation") didn't actually work out for the other types of operations. This is all just figuring out a stopgap, T12935 and other changes should eventually provide real pathways here. Test Plan: Straight revert. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D18281 --- .../controller/DifferentialRevisionViewController.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php index edf65b01ea..ab03ee6d81 100644 --- a/src/applications/differential/controller/DifferentialRevisionViewController.php +++ b/src/applications/differential/controller/DifferentialRevisionViewController.php @@ -1051,14 +1051,14 @@ final class DifferentialRevisionViewController extends DifferentialController { return null; } - // NOTE: The upstream currently supports only "Land" operations, but - // third parties have other operations (see PHI18). For now, we show any - // operation that exists. We'll refine this in the future. - $operations = id(new DrydockRepositoryOperationQuery()) ->setViewer($viewer) ->withObjectPHIDs(array($revision->getPHID())) ->withIsDismissed(false) + ->withOperationTypes( + array( + DrydockLandRepositoryOperation::OPCONST, + )) ->execute(); if (!$operations) { return null;