Link to undisplayed inline comments
Summary: We currently don't link to comments which aren't visible. Link to the appropriate diff in a new window, indicating where the comment lives. Test Plan: Clicked visible, not-so-visible comments. Reviewers: btrahan, jungejason, davidreuss Reviewed By: btrahan CC: aran, btrahan, epriestley Maniphest Tasks: T555, T449 Differential Revision: https://secure.phabricator.com/D1333
This commit is contained in:
@@ -210,6 +210,7 @@ class DifferentialRevisionViewController extends DifferentialController {
|
||||
$comment_view->setChangesets($all_changesets);
|
||||
$comment_view->setUser($user);
|
||||
$comment_view->setTargetDiff($target);
|
||||
$comment_view->setVersusDiffID($diff_vs);
|
||||
|
||||
$changeset_view = new DifferentialChangesetListView();
|
||||
$changeset_view->setChangesets($visible_changesets);
|
||||
|
||||
Reference in New Issue
Block a user