From e6684af73cec61ade06d548f78b95f45166536fc Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Tue, 30 Dec 2014 02:51:31 -0800 Subject: [PATCH] Let JSHint know that the `show_details` function is an exported global Summary: The `show_details` function is used by DarkConsole. Adding this comment silences the following JSHint warning: ``` >>> Lint for webroot/rsrc/js/core/behavior-error-log.js: Warning (W098) JSHintW098 'show_details' is defined but never used. 5 6 var current_details = null; 7 >>> 8 function show_details(row) { 9 var node = JX.$('row-details-' + row); 10 11 if (current_details !== null) { ``` Test Plan: `arc lint` Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11063 --- resources/celerity/map.php | 12 ++++++------ webroot/rsrc/js/core/behavior-error-log.js | 2 ++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 8a7d0efc4f..7805b2609f 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -9,7 +9,7 @@ return array( 'names' => array( 'core.pkg.css' => 'f588bfc3', 'core.pkg.js' => '2d1f7db1', - 'darkconsole.pkg.js' => 'df001cab', + 'darkconsole.pkg.js' => 'ac37f0cd', 'differential.pkg.css' => '8af45893', 'differential.pkg.js' => '42c10e78', 'diffusion.pkg.css' => '591664fa', @@ -450,7 +450,7 @@ return array( 'rsrc/js/core/behavior-dark-console.js' => '357b6e9b', 'rsrc/js/core/behavior-device.js' => '03d6ed07', 'rsrc/js/core/behavior-drag-and-drop-textarea.js' => '92eb531d', - 'rsrc/js/core/behavior-error-log.js' => 'a5d7cf86', + 'rsrc/js/core/behavior-error-log.js' => '6882e80a', 'rsrc/js/core/behavior-fancy-datepicker.js' => 'c51ae228', 'rsrc/js/core/behavior-file-tree.js' => '88236f00', 'rsrc/js/core/behavior-form.js' => '5c54cbf3', @@ -577,7 +577,7 @@ return array( 'javelin-behavior-diffusion-locate-file' => '6d3e1947', 'javelin-behavior-diffusion-pull-lastmodified' => '2b228192', 'javelin-behavior-doorkeeper-tag' => 'e5822781', - 'javelin-behavior-error-log' => 'a5d7cf86', + 'javelin-behavior-error-log' => '6882e80a', 'javelin-behavior-fancy-datepicker' => 'c51ae228', 'javelin-behavior-global-drag-and-drop' => '07f199d8', 'javelin-behavior-herald-rule-editor' => '7ebaeed3', @@ -1218,6 +1218,9 @@ return array( 'javelin-dom', 'javelin-fx', ), + '6882e80a' => array( + 'javelin-dom', + ), '6932def3' => array( 'javelin-behavior', 'javelin-stratcom', @@ -1482,9 +1485,6 @@ return array( 'javelin-dom', 'phabricator-notification', ), - 'a5d7cf86' => array( - 'javelin-dom', - ), 'a80d0378' => array( 'javelin-behavior', 'javelin-stratcom', diff --git a/webroot/rsrc/js/core/behavior-error-log.js b/webroot/rsrc/js/core/behavior-error-log.js index e8d6b0136f..24f3f61141 100644 --- a/webroot/rsrc/js/core/behavior-error-log.js +++ b/webroot/rsrc/js/core/behavior-error-log.js @@ -3,6 +3,8 @@ * @requires javelin-dom */ +/* exported show_details */ + var current_details = null; function show_details(row) {