From e850bc6b957a8ac6c6faa02d57716ce5d60d42f6 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 27 Nov 2017 16:54:26 -0800 Subject: [PATCH] When requiring login signatures, order documents from oldest to newest Summary: Depends on D18788. Ref T13024. Currently, we prompt users to sign from newest to oldest. This seems less intuitive than oldest to newest. Test Plan: Dumped document order, saw it swap to oldest-first. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13024 Differential Revision: https://secure.phabricator.com/D18789 --- src/applications/base/controller/PhabricatorController.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php index 961e85effe..fb9c402083 100644 --- a/src/applications/base/controller/PhabricatorController.php +++ b/src/applications/base/controller/PhabricatorController.php @@ -560,6 +560,7 @@ abstract class PhabricatorController extends AphrontController { ->setViewer($viewer) ->withSignatureRequired(1) ->needViewerSignatures(true) + ->setOrder('oldest') ->execute(); $must_sign_docs = array();