archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fixing a bug in the bot ignore logic to use sender.

Browse Source 
Summary: Also added sender to the campfire adapter. This isn't extremely useful as it's just a numeric id, but it allows us to add ignores (specifically having the bot ignore itself).

Test Plan: Ran the bot, ignored itself.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4893
This commit is contained in:
indiefan
2013-02-09 16:10:16 -08:00
committed by epriestley
parent 0f8984f5a7
commit eaa72c6155
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/infrastructure/daemon/bot/PhabricatorBot.php
View File

@@ -107,7 +107,7 @@ final class PhabricatorBot extends PhabricatorDaemon {
private function routeMessage(PhabricatorBotMessage $message) { private function routeMessage(PhabricatorBotMessage $message) {
$ignore = $this->getConfig('ignore'); $ignore = $this->getConfig('ignore');
if ($ignore && in_array($message->getSenderNickName(), $ignore)) { if ($ignore && in_array($message->getSender(), $ignore)) {
return; return;
} }

1
src/infrastructure/daemon/bot/adapter/PhabricatorCampfireProtocolAdapter.php
View File

@@ -118,6 +118,7 @@ extends PhabricatorBaseProtocolAdapter {
return id(new PhabricatorBotMessage()) return id(new PhabricatorBotMessage())
->setCommand('MESSAGE') ->setCommand('MESSAGE')
->setSender($m_obj['user_id'])
->setTarget($m_obj['room_id']) ->setTarget($m_obj['room_id'])
->setBody($m_obj['body']); ->setBody($m_obj['body']);
} }