From ec8dbfd05f43e408af4fbf47609c465a91620a3c Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Tue, 22 Nov 2011 10:14:11 -0800 Subject: [PATCH] Dedupe DIRECTORY w/ Directory tab in directory header Summary: the tab is a bit silly right next to DIRECTORY Test Plan: viewed phabricator with an admin account * looks good on load * clicked Categories and Items; looked good viewed phabricator with a non-admin account * looks good on load * nothing else to click in the header Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: 1131 --- .../base/PhabricatorDirectoryController.php | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/applications/directory/controller/base/PhabricatorDirectoryController.php b/src/applications/directory/controller/base/PhabricatorDirectoryController.php index 2448113412..e4000f9142 100644 --- a/src/applications/directory/controller/base/PhabricatorDirectoryController.php +++ b/src/applications/directory/controller/base/PhabricatorDirectoryController.php @@ -30,15 +30,8 @@ abstract class PhabricatorDirectoryController extends PhabricatorController { $page->setBaseURI('/'); $page->setTitle(idx($data, 'title')); - $tabs = array( - 'directory' => array( - 'href' => '/', - 'name' => 'Directory', - ), - ); - if ($this->getRequest()->getUser()->getIsAdmin()) { - $tabs += array( + $tabs = array( 'categories' => array( 'href' => '/directory/category/', 'name' => 'Categories', @@ -48,6 +41,8 @@ abstract class PhabricatorDirectoryController extends PhabricatorController { 'name' => 'Items', ), ); + } else { + $tabs = array(); } $page->setTabs(