From f5235f7e09eb801c90f7688fb65f5eac3f28a47e Mon Sep 17 00:00:00 2001 From: Chad Little Date: Mon, 3 Nov 2014 09:31:23 -0800 Subject: [PATCH] Make loading large changesets slightly easier Summary: Fixes T3942, turns the load links into buttons. Test Plan: Set my limit to 1, test page. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T3942 Differential Revision: https://secure.phabricator.com/D10775 --- .../controller/DifferentialRevisionViewController.php | 5 +++-- .../differential/view/DifferentialChangesetListView.php | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php index 7a801c72ac..e2afe57248 100644 --- a/src/applications/differential/controller/DifferentialRevisionViewController.php +++ b/src/applications/differential/controller/DifferentialRevisionViewController.php @@ -145,12 +145,13 @@ final class DifferentialRevisionViewController extends DifferentialController { $warning->appendChild(hsprintf( '%s %s', pht( - 'This diff is very large and affects %s files. Load each file '. - 'individually.', + 'This diff is very large and affects %s files. '. + 'You may load each file individually or ', new PhutilNumber($count)), phutil_tag( 'a', array( + 'class' => 'button grey', 'href' => $request_uri ->alter('large', 'true') ->setFragment('toc'), diff --git a/src/applications/differential/view/DifferentialChangesetListView.php b/src/applications/differential/view/DifferentialChangesetListView.php index afdc75c451..55d0d071f4 100644 --- a/src/applications/differential/view/DifferentialChangesetListView.php +++ b/src/applications/differential/view/DifferentialChangesetListView.php @@ -175,6 +175,7 @@ final class DifferentialChangesetListView extends AphrontView { $load = javelin_tag( 'a', array( + 'class' => 'button grey', 'href' => '#'.$uniq_id, 'sigil' => 'differential-load', 'meta' => array( @@ -183,7 +184,7 @@ final class DifferentialChangesetListView extends AphrontView { ), 'mustcapture' => true, ), - pht('Load')); + pht('Load File')); } $detail->appendChild( phutil_tag(