From fcaeb2aeb6d9e38a26d2d28d2ec9cafbc0aaa745 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@joshuaspence.com>
Date: Mon, 23 Jun 2014 04:07:52 +1000
Subject: [PATCH] Be more strict with JSHint.

Summary: Add a bunch of extra checks to be performed by `jshint`. For documentation, see http://jshint.com/docs/options/.

Test Plan:
Ran `jshint --config support/jshint/jshintconfig webroot/rsrc/js/`. There were a bunch of existing violations, but some of these are legitimate and probably require attention.

```lang=json
{
  "bitwise": true, // 0 violations
  "curly": true, // 0 violations
  "immed": true, // 1 violation
  "indent": 2, // 0 violations
  "latedef": true, // 10 violations
  "newcap": true, // 1 violation
  "noarg": true, // 0 violations
  "quotmark": "single", // 55 violations
  "undef": true, // 24 violations
  "unused": true, // 107 violations

  "expr": true,
  "loopfunc": true,
  "sub": true,

  "globals": {
    "JX": false,
    "__DEV__": false
  },
  "browser": true
}
```

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9659
---
 support/jshint/jshintconfig | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/support/jshint/jshintconfig b/support/jshint/jshintconfig
index e753307f4a..900cf7d115 100644
--- a/support/jshint/jshintconfig
+++ b/support/jshint/jshintconfig
@@ -1,5 +1,22 @@
 {
-  "expr" : true,
-  "loopfunc" : true,
-  "sub" : true
+  "bitwise": true,
+  "curly": true,
+  "immed": true,
+  "indent": 2,
+  "latedef": true,
+  "newcap": true,
+  "noarg": true,
+  "quotmark": "single",
+  "undef": true,
+  "unused": true,
+
+  "expr": true,
+  "loopfunc": true,
+  "sub": true,
+
+  "globals": {
+    "JX": false,
+    "__DEV__": false
+  },
+  "browser": true
 }