From fddd46740064220fc6458292463a27a2d5a9991c Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Sun, 11 Dec 2016 17:21:16 +0000
Subject: [PATCH] Fake an outline ring on buttons

Summary: Fixes T11990. Chrome/Ubuntu doesn't respect `outline: auto`, so this is the only workaround I could fine. Somewhat nicer than stock Chrome.

Test Plan: tab tab tab tab, ubuntu, chrome, windows, safari.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T11990

Differential Revision: https://secure.phabricator.com/D17023
---
 resources/celerity/map.php            |  6 +++---
 webroot/rsrc/css/phui/phui-button.css | 11 +++++++++--
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 7771a79107..432d76abd3 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@ return array(
   'names' => array(
     'conpherence.pkg.css' => '0b64e988',
     'conpherence.pkg.js' => '6249a1cf',
-    'core.pkg.css' => '35e6c1ed',
+    'core.pkg.css' => '1ef46ae8',
     'core.pkg.js' => 'e4260032',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'a4ba74b5',
@@ -128,7 +128,7 @@ return array(
     'rsrc/css/phui/phui-basic-nav-view.css' => '7093573b',
     'rsrc/css/phui/phui-big-info-view.css' => 'bd903741',
     'rsrc/css/phui/phui-box.css' => '5c8387cf',
-    'rsrc/css/phui/phui-button.css' => '4a5fbe3d',
+    'rsrc/css/phui/phui-button.css' => '43f4912e',
     'rsrc/css/phui/phui-chart.css' => '6bf6f78e',
     'rsrc/css/phui/phui-cms.css' => 'be43c8a8',
     'rsrc/css/phui/phui-comment-form.css' => 'c953b75e',
@@ -837,7 +837,7 @@ return array(
     'phui-basic-nav-view-css' => '7093573b',
     'phui-big-info-view-css' => 'bd903741',
     'phui-box-css' => '5c8387cf',
-    'phui-button-css' => '4a5fbe3d',
+    'phui-button-css' => '43f4912e',
     'phui-calendar-css' => '477acfaa',
     'phui-calendar-day-css' => '572b1893',
     'phui-calendar-list-css' => 'fcc9fb41',
diff --git a/webroot/rsrc/css/phui/phui-button.css b/webroot/rsrc/css/phui/phui-button.css
index 51807fa48e..15142d3b1a 100644
--- a/webroot/rsrc/css/phui/phui-button.css
+++ b/webroot/rsrc/css/phui/phui-button.css
@@ -17,9 +17,16 @@ button.phabricator-action-view-item {
   -webkit-font-smoothing: auto;
 }
 
-button::-moz-focus-inner {
-  padding: 0;
+button::-moz-focus-inner,
+input::-moz-focus-inner {
   border: 0;
+  padding: 0;
+}
+
+button:focus,
+a.button:focus {
+  outline: 0;
+  box-shadow: 0 0 2pt 2pt rgba(82, 168, 236, 0.7);
 }
 
 button,