9bbce8de42
Summary: Currently, we give you an "Install" button for Beta apps even when "phabricator.show-beta-applications" is disabled. This is unclear. Instead, disable the button and tell the user about the config when it is clicked. Arguably, we should restructure this so you can selectively install "Beta" apps without setting the config, but almost all the beta apps are terrible so just make things consistent for now. Test Plan: Tried to install a beta app without beta apps enabled. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5652
94 lines
2.8 KiB
PHP
94 lines
2.8 KiB
PHP
<?php
|
|
|
|
final class PhabricatorApplicationUninstallController
|
|
extends PhabricatorApplicationsController {
|
|
|
|
private $application;
|
|
private $action;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->application = $data['application'];
|
|
$this->action = $data['action'];
|
|
}
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$selected = PhabricatorApplication::getByClass($this->application);
|
|
|
|
if (!$selected) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$view_uri = $this->getApplicationURI('view/'.$this->application);
|
|
|
|
$beta_enabled = PhabricatorEnv::getEnvConfig(
|
|
'phabricator.show-beta-applications');
|
|
|
|
$dialog = id(new AphrontDialogView())
|
|
->setUser($user)
|
|
->addCancelButton($view_uri);
|
|
|
|
if ($selected->isBeta() && !$beta_enabled) {
|
|
$dialog
|
|
->setTitle(pht('Beta Applications Not Enabled'))
|
|
->appendChild(
|
|
pht(
|
|
'To manage beta applications, enable them by setting %s in your '.
|
|
'Phabricator configuration.',
|
|
phutil_tag('tt', array(), 'phabricator.show-beta-applications')));
|
|
return id(new AphrontDialogResponse())->setDialog($dialog);
|
|
}
|
|
|
|
if ($request->isDialogFormPost()) {
|
|
$this->manageApplication();
|
|
return id(new AphrontRedirectResponse())->setURI($view_uri);
|
|
}
|
|
|
|
if ($this->action == 'install') {
|
|
if ($selected->canUninstall()) {
|
|
$dialog->setTitle('Confirmation')
|
|
->appendChild(
|
|
'Install '. $selected->getName(). ' application?')
|
|
->addSubmitButton('Install');
|
|
|
|
} else {
|
|
$dialog->setTitle('Information')
|
|
->appendChild('You cannot install an installed application.');
|
|
}
|
|
} else {
|
|
if ($selected->canUninstall()) {
|
|
$dialog->setTitle('Confirmation')
|
|
->appendChild(
|
|
'Really Uninstall '. $selected->getName(). ' application?')
|
|
->addSubmitButton('Uninstall');
|
|
} else {
|
|
$dialog->setTitle('Information')
|
|
->appendChild(
|
|
'This application cannot be uninstalled,
|
|
because it is required for Phabricator to work.');
|
|
}
|
|
}
|
|
return id(new AphrontDialogResponse())->setDialog($dialog);
|
|
}
|
|
|
|
public function manageApplication() {
|
|
$key = 'phabricator.uninstalled-applications';
|
|
$config_entry = PhabricatorConfigEntry::loadConfigEntry($key);
|
|
$list = $config_entry->getValue();
|
|
$uninstalled = PhabricatorEnv::getEnvConfig($key);
|
|
|
|
if (isset($uninstalled[$this->application])) {
|
|
unset($list[$this->application]);
|
|
} else {
|
|
$list[$this->application] = true;
|
|
}
|
|
|
|
PhabricatorConfigEditor::storeNewValue(
|
|
$config_entry, $list, $this->getRequest());
|
|
}
|
|
|
|
}
|
|
|