e2f0571104
Summary: Ref T920. Ref T7477. We currently drop empty mail only once it reaches the `ReplyHandler` layer. I think no plausible receiver can ever do anything useful with this kind of mail, so we can safely drop it earlier and simplify some of the logic. After T7477, we'd end up throwing multiple exceptions if you sent empty mail to several valid receivers. (I also want to move away from APIs oriented around raw addresses in more specialized layers, and this is one of the few callsites for raw mail address information.) This requires updating some unit tests to actually have message bodies, since they failed with this error before hitting the other errors otherwise. Test Plan: Used `bin/mail receive-test` to send empty mail, got appropriate "err:empty" out of it. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T7477, T920 Differential Revision: https://secure.phabricator.com/D19947
Phabricator is a collection of web applications which help software companies build better software.
Phabricator includes applications for:
- reviewing and auditing source code;
- hosting and browsing repositories;
- tracking bugs;
- managing projects;
- conversing with team members;
- assembling a party to venture forth;
- writing stuff down and reading it later;
- hiding stuff from coworkers; and
- also some other things.
You can learn more about the project (and find links to documentation and resources) at Phabricator.org
Phabricator is developed and maintained by Phacility.
SUPPORT RESOURCES
For resources on filing bugs, requesting features, reporting security issues, and getting other kinds of support, see Support Resources.
NO PULL REQUESTS!
We do not accept pull requests through GitHub. If you would like to contribute code, please read our Contributor's Guide.
LICENSE
Phabricator is released under the Apache 2.0 license except as otherwise noted.