f95710e799
Summary: Fixes T2820 Grepped for `PhabricatorFileImageMacro`, a common approach to load image macros from storage. Cleaned up file loading too (in most cases where I could be sure that I won't break anything). Did not touch the `add_macro.php` util script, since many users will assume the user `ubuntu` or `ec2-user` to run the script. Add no sessions and no CSRF protection measures... Test Plan: Browsed around all kinds of places. Created and looked at memes, created and edited macros. Used them in Remarkup (with flushed cache). Used `macro.query`, verified it did not crash (that's always a good sign). Could not verify object handles, since I have no idea where they appear right now. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2820 Differential Revision: https://secure.phabricator.com/D5418
65 lines
1.9 KiB
PHP
65 lines
1.9 KiB
PHP
<?php
|
|
|
|
final class PhabricatorMacroDisableController
|
|
extends PhabricatorMacroController {
|
|
|
|
private $id;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->id = $data['id'];
|
|
}
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$macro = id(new PhabricatorMacroQuery())
|
|
->setViewer($user)
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
))
|
|
->withIDs(array($this->id))
|
|
->executeOne();
|
|
if (!$macro) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$view_uri = $this->getApplicationURI('/view/'.$this->id.'/');
|
|
|
|
if ($request->isDialogFormPost() || $macro->getIsDisabled()) {
|
|
$xaction = id(new PhabricatorMacroTransaction())
|
|
->setTransactionType(PhabricatorMacroTransactionType::TYPE_DISABLED)
|
|
->setNewValue($macro->getIsDisabled() ? 0 : 1);
|
|
|
|
$editor = id(new PhabricatorMacroEditor())
|
|
->setActor($user)
|
|
->setContentSource(
|
|
PhabricatorContentSource::newForSource(
|
|
PhabricatorContentSource::SOURCE_WEB,
|
|
array(
|
|
'ip' => $request->getRemoteAddr(),
|
|
)));
|
|
|
|
$xactions = $editor->applyTransactions($macro, array($xaction));
|
|
|
|
return id(new AphrontRedirectResponse())->setURI($view_uri);
|
|
}
|
|
|
|
$dialog = new AphrontDialogView();
|
|
$dialog
|
|
->setUser($request->getUser())
|
|
->setTitle(pht('Really disable macro?'))
|
|
->appendChild(phutil_tag('p', array(), pht(
|
|
'Really disable the much-beloved image macro %s? '.
|
|
'It will be sorely missed.',
|
|
$macro->getName())))
|
|
->setSubmitURI($this->getApplicationURI('/disable/'.$this->id.'/'))
|
|
->addSubmitButton(pht('Disable'))
|
|
->addCancelButton($view_uri);
|
|
|
|
return id(new AphrontDialogResponse())->setDialog($dialog);
|
|
}
|
|
}
|