archive/pillar
0
0
Fork 0
Code Issues 42 Pull Requests Projects Releases Wiki Activity

Prevent accessing /nodes/undefined/view from search pages.

Browse Source 
`firstHit.attr('data-hit-id')` can be undefined; in that case we just
ignore the siutation.

Furthermore, I've removed the call to clearTimeout(), as it is only
called after the timeout has been hit, and thus is a no-op.
This commit is contained in:
Sybren A. Stüvel 2016-09-06 11:56:54 +02:00
parent 305d9b44ec
commit 574178cffc
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/scripts/algolia_search.js
View File

@ -82,17 +82,24 @@ $(document).ready(function() {
firstHit.addClass('active');
firstHit.find('#search-loading').addClass('active');
var getNode = setTimeout(function() {
$.get('/nodes/' + firstHit.attr('data-hit-id') + '/view', function(dataHtml) {
$('#search-hit-container').html(dataHtml);
})
.done(function() {
function done() {
$('.search-loading').removeClass('active');
$('#search-error').hide();
$('#search-hit-container').show();
}
clearTimeout(getNode);
window.setTimeout(function() {
// Ignore getting that first result when there is none.
var hit_id = firstHit.attr('data-hit-id');
if (hit_id === undefined) {
done();
return;
}
$.get('/nodes/' + hit_id + '/view', function(dataHtml) {
$('#search-hit-container').html(dataHtml);
})
.done(done)
.fail(function(data) {
$('.search-loading').removeClass('active');
$('#search-hit-container').hide();