Node edit: take texture map type into account when renaming files at GCS.

pillar/application/modules/nodes.py

@@ -65,6 +65,7 @@ def resource_parse_attachments(response):
     for item in response['_items']:
         item_parse_attachments(item)
 
+
 def before_replacing_node(item, original):
     check_permissions('nodes', original, 'PUT')
     update_file_name(item)

pillar/application/utils/gcs.py

@@ -135,55 +135,55 @@ class GoogleCloudStorageBucket(object):
         """Set the ContentDisposition metadata so that when a file is downloaded
         it has a human-readable name.
         """
-        blob.content_disposition = 'attachment; filename="{0}"'.format(name)
+        blob.content_disposition = u'attachment; filename="{0}"'.format(name)
         blob.patch()
 
 
-def update_file_name(item):
+def update_file_name(node):
     """Assign to the CGS blob the same name of the asset node. This way when
     downloading an asset we get a human-readable name.
     """
 
-    def _format_name(name, format, size=None):
+    # Process only files that are not processing
-        # If the name already has an extention, and such extension matches the
+    if node['properties']['status'] == 'processing':
-        # format, only inject the size.
+        return
-        root, ext = os.path.splitext(name)
-        size = "-{0}".format(size) if size else ''
-        ext = ext if len(ext) > 1 and ext[1:] == format else ".{0}".format(format)
-        return "{0}{1}{2}".format(root, size, ext)
 
-    def _update_name(item, file_id):
+    def _format_name(name, override_ext, size=None, map_type=u''):
+        root, _ = os.path.splitext(name)
+        size = u'-{}'.format(size) if size else u''
+        map_type = u'-{}'.format(map_type) if map_type else u''
+        return u'{}{}{}{}'.format(root, size, map_type, override_ext)
+
+    def _update_name(file_id, file_props):
         files_collection = current_app.data.driver.db['files']
-        f = files_collection.find_one({'_id': ObjectId(file_id)})
+        file_doc = files_collection.find_one({'_id': ObjectId(file_id)})
-        status = item['properties']['status']
+
-        if f and f['backend'] == 'gcs' and status != 'processing':
+        if file_doc is None or file_doc['backend'] != 'gcs':
-            # Process only files that are on GCS and that are not processing
+            return
-            try:
+
-                storage = GoogleCloudStorageBucket(str(item['project']))
+        # For textures -- the map type should be part of the name.
-                blob = storage.Get(f['file_path'], to_dict=False)
+        map_type = file_props.get('map_type', u'')
+
+        storage = GoogleCloudStorageBucket(str(node['project']))
+        blob = storage.Get(file_doc['file_path'], to_dict=False)
         # Pick file extension from original filename
-                _, ext = os.path.splitext(f['filename'])
+        _, ext = os.path.splitext(file_doc['filename'])
-                name = _format_name(item['name'], ext[1:])
+        name = _format_name(node['name'], ext, map_type=map_type)
         storage.update_name(blob, name)
-                try:
+
         # Assign the same name to variations
-                    for v in f['variations']:
+        for v in file_doc['variations']:
+            _, override_ext = os.path.splitext(v['file_path'])
+            name = _format_name(node['name'], override_ext, v['size'], map_type=map_type)
             blob = storage.Get(v['file_path'], to_dict=False)
-                        name = _format_name(item['name'], v['format'], v['size'])
             storage.update_name(blob, name)
-                except KeyError:
-                    pass
-            except AttributeError:
-                bugsnag.notify(Exception('Missing or conflicting ids detected'),
-                               meta_data={'nodes_info':
-                                              {'node_id': item['_id'], 'file_id': file_id}})
 
     # Currently we search for 'file' and 'files' keys in the object properties.
     # This could become a bit more flexible and realy on a true reference of the
     # file object type from the schema.
-    if 'file' in item['properties']:
+    if 'file' in node['properties']:
-        _update_name(item, item['properties']['file'])
+        _update_name(node['properties']['file'], {})
 
-    elif 'files' in item['properties']:
+    if 'files' in node['properties']:
-        for f in item['properties']['files']:
+        for file_props in node['properties']['files']:
-            _update_name(item, f['file'])
+            _update_name(file_props['file'], file_props)