From 7e941e22999471a6871636eb0dd9f96262ce2479 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= <sybren@stuvel.eu>
Date: Wed, 3 Oct 2018 14:20:29 +0200
Subject: [PATCH] Added TODOs and removed fetching unused field from MongoDB

---
 pillar/badge_sync.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pillar/badge_sync.py b/pillar/badge_sync.py
index 40db6d7f..194160aa 100644
--- a/pillar/badge_sync.py
+++ b/pillar/badge_sync.py
@@ -33,7 +33,7 @@ def find_users_to_sync() -> typing.Iterable[SyncUser]:
         {'$match': {
             'token': {'$exists': True},
             'oauth_scopes': 'badge',
-            'expire_time': {'$gt': now},
+            'expire_time': {'$gt': now},  # TODO(Sybren): save real token expiry time but keep checking tokens hourly when they are used!
         }},
         {'$lookup': {
             'from': 'users',
@@ -62,7 +62,6 @@ def find_users_to_sync() -> typing.Iterable[SyncUser]:
             'token': True,
             'user._id': True,
             'user.auth.user_id': True,
-            'user.badges.expires': True,
         }},
     ])
 
@@ -101,6 +100,7 @@ def fetch_badge_html(session: requests.Session, user: SyncUser, size: str) \
         my_log.debug('No badges for user %s', user.user_id)
         return ''
     if resp.status_code == 403:
+        # TODO(Sybren): this indicates the token is invalid, so we could just as well delete it.
         my_log.warning('Tried fetching %s for user %s but received a 403: %s',
                        url, user.user_id, resp.text)
         return ''