From de8bff51b525cd8d3883f8479a6461a1e0166247 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= Date: Tue, 27 Mar 2018 11:50:09 +0200 Subject: [PATCH] Added TODO: keep Sentry unconfigured when running CLI commands. When running CLI stuff the logging is seen by human eyes anyway, so we don't need to send things to Sentry. --- pillar/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pillar/__init__.py b/pillar/__init__.py index 0eecdbe0..458e113c 100644 --- a/pillar/__init__.py +++ b/pillar/__init__.py @@ -223,6 +223,7 @@ class PillarServer(BlinkerCompatibleEve): self.log.info('Git revision %r', self.config['GIT_REVISION']) def _config_sentry(self): + # TODO(Sybren): keep Sentry unconfigured when running CLI commands. sentry_dsn = self.config.get('SENTRY_CONFIG', {}).get('dsn') if self.config.get('TESTING') or sentry_dsn in {'', '-set-in-config-local-'}: self.log.warning('Sentry NOT configured.')