aryeramaty/blender
0
0
Fork 1
forked from blender/blender
Code Pull Requests Activity

davidhaver-WIP-realize-depth #2

Merged
Arye Ramaty merged 11 commits from David-Haver/blender-old:davidhaver-WIP-realize-depth into WIP-realize-depth 2024-03-21 14:55:23 +01:00
Conversation 0 Commits 11 Files Changed 5 -9
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 92b690bf12 - Show all commits

9
source/blender/geometry/intern/realize_instances.cc
View File

@ -2,23 +2,14 @@
* *
aryeramaty marked this conversation as resolved
Arye Ramaty commented 2024-03-21 12:15:01 +01:00
Review
Copy Link

As a general rule, I'll try to minimize the length of the PR, aiming to stay as close as possible to origin/main. I believe things like 'include clean-up' can wait for a later PR.

As a general rule, I'll try to minimize the length of the PR, aiming to stay as close as possible to origin/main. I believe things like 'include clean-up' can wait for a later PR.
David-Haver commented 2024-03-21 13:09:02 +01:00
Review
Copy Link

The changes were done mainly to the code you add and to thing that changed because of it.
New included made some other unnecessary.

The changes were done mainly to the code you add and to thing that changed because of it. New included made some other unnecessary.
Arye Ramaty commented 2024-03-21 14:52:45 +01:00
Review
Copy Link

Fair enough

Fair enough
* SPDX-License-Identifier: GPL-2.0-or-later */ * SPDX-License-Identifier: GPL-2.0-or-later */
#include "BKE_geometry_set.hh"
#include "GEO_join_geometries.hh" #include "GEO_join_geometries.hh"
#include "GEO_realize_instances.hh" #include "GEO_realize_instances.hh"
#include "DNA_collection_types.h" #include "DNA_collection_types.h"
#include "DNA_layer_types.h"
#include "DNA_object_types.h"
#include "DNA_pointcloud_types.h"
#include "BLI_array_utils.hh" #include "BLI_array_utils.hh"
#include "BLI_listbase.h"
#include "BLI_math_matrix.hh"
#include "BLI_math_rotation.hh"
#include "BLI_noise.hh" #include "BLI_noise.hh"
#include "BLI_task.hh"
#include "BKE_collection.hh"
#include "BKE_curves.hh" #include "BKE_curves.hh"
#include "BKE_customdata.hh" #include "BKE_customdata.hh"
#include "BKE_geometry_set_instances.hh" #include "BKE_geometry_set_instances.hh"