Arye Ramaty aryeramaty
  • Joined on 2018-06-10
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-03-21 14:55:23 +01:00
4370ae85cf davidhaver-WIP-realize-depth
059c73dc9f returned std::max(value, 0) in depth_override
a331c835f2 SpecificInstancesChoice -> VariedDepthOption
7f42563d71 resolve conflict?
9ce905cbaa making the code more readable
Compare 12 commits »
Arye Ramaty commented on pull request aryeramaty/blender#2 2024-03-21 14:53:00 +01:00
davidhaver-WIP-realize-depth

OK

Arye Ramaty commented on pull request aryeramaty/blender#2 2024-03-21 14:52:46 +01:00
davidhaver-WIP-realize-depth

Fair enough

Arye Ramaty commented on pull request aryeramaty/blender#2 2024-03-21 14:32:45 +01:00
davidhaver-WIP-realize-depth

The user can enter -1; the .min(0) serves as a 'soft limit,' implying that the user can still set the value lower than 0 by either typing a specific value (instead of scrubbing) or connecting the…

Arye Ramaty commented on pull request aryeramaty/blender#2 2024-03-21 12:49:04 +01:00
davidhaver-WIP-realize-depth

The use of std::max was intentional. We aim to prevent users from entering -1 into the field. Instead, we provide the 'realize all' option for that purpose.

Arye Ramaty commented on pull request aryeramaty/blender#2 2024-03-21 12:49:04 +01:00
davidhaver-WIP-realize-depth

As a general rule, I'll try to minimize the length of the PR, aiming to stay as close as possible to origin/main. I believe things like 'include clean-up' can wait for a later PR.

Arye Ramaty commented on pull request aryeramaty/blender#2 2024-03-21 12:49:04 +01:00
davidhaver-WIP-realize-depth

This is fine, but I'm not sure about the name 'SpecificInstancesChoice'. I think something like 'SelectionAndDepthOption' may be clearer. Alternatively, 'VariedDepthOption' could also work.

Arye Ramaty commented on pull request aryeramaty/blender#2 2024-03-21 12:49:04 +01:00
davidhaver-WIP-realize-depth

I would rather not make clean-up or style changes to files I didn't modify in the PR. It just makes it a little bit harder to see what has changed.

Arye Ramaty suggested changes for aryeramaty/blender#2 2024-03-21 12:49:04 +01:00
davidhaver-WIP-realize-depth

I didn't have time to review all the changes in the 'realize_instance' file, but that's it for now.

Arye Ramaty merged pull request aryeramaty/blender#1 2024-03-14 14:13:05 +01:00
davidhaver-WIP-realize-depth
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-03-14 14:13:04 +01:00
e62ed2622f davidhaver-WIP-realize-depth
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-03-10 12:25:11 +01:00
bcf559122f Merge branch 'main' into WIP-realize-depth
5ad9f9dc90 Cleanup: unused includes in source/blender/io
5b522359ee Cleanup: Centralize MSVC conformance related cmake items
61a88e525b Windows libs: OSL 1.13.7, OIDN 2.2.1
e33f5e36ac Cleanup: spacing around C-style comment blocks
Compare 420 commits »
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-03-03 17:39:40 +01:00
f421076caa Introduce 'geometry_set_from_reference' for better abstraction.
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-03-03 12:02:29 +01:00
ef43c9db4d Move specialised function to the geometry module
Arye Ramaty pushed to move-stuff-around at aryeramaty/blender 2024-03-03 11:53:02 +01:00
b7b075fa9d remove redundant include
Arye Ramaty pushed to move-stuff-around at aryeramaty/blender 2024-03-03 11:51:47 +01:00
f60f2e670f Remove attribute_foreach varioation
Arye Ramaty pushed to move-stuff-around at aryeramaty/blender 2024-03-03 09:45:23 +01:00
9949f26e0d move the attribute_foreach function to realize_instances
32c2b5de4b remove code in geometry_set.cc
2d14940626 remove comment out code
56dd54e6f8 add local gather_attributes_for_propagation to realize_instances.cc
Compare 4 commits »
Arye Ramaty created branch move-stuff-around in aryeramaty/blender 2024-03-03 09:45:23 +01:00
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-02-28 15:32:30 +01:00
e4100aee8c Fix Merge "Conflicts"
d5ca8fa4fa Merge branch 'main' into WIP-realize-depth
de5451b112 Cleanup: Move BKE_anim_data header to be fully C++.
44810e137f Merge branch 'blender-v4.1-release'
9060b0dfb7 Cleanup: Correction to type annotation and smaller fixes/optimizations
Compare 469 commits »
Arye Ramaty pushed to WIP-realize-depth at aryeramaty/blender 2024-02-25 14:49:15 +01:00
f7dee8752b Fix compiler optimazation error