Auto Mirror addon: promote 2.79 addons release #50941
Closed
opened 6 years ago by BrendonMurphy
·
12 comments
No Milestone
No project
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender-addons#50941
Loading…
Reference in new issue
There is no content yet.
Delete Branch '%!s(<nil>)'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Hi
this is the task for the Auto Mirror addon by @Lapineige
My request; https://github.com/lapineige/Blender_add-ons/issues/1#issuecomment-286167183
Original Code: https://github.com/lapineige/Blender_add-ons/blob/master/AutoMirror/AutoMirror_V2-4.py
French forum link: http://blenderlounge.fr/addon-auto-mirror/
This addon keeps appearing in many places, being widely used by users & addons devs.
Thanks.
Changed status to: 'Open'
Added subscribers: @Lapineige, @BrendonMurphy
Auto Mirror addon: promote 2,79 addons releaseto Auto Mirror addon: promote 2.79 addons release 6 years agoHello @BrendonMurphy,
I'm really pleased that you appreciate my add-on enough to submit it here :) (but I'd be kind to tell me before :P)
However, I don't think it's useful nor a good idea. It's a dirty piece of code (not even PEP-8 compliant) that I made 3 years ago for some friends, not something meant to be a big add-on or something to integrate inside of Blender.
It's just a simple one click add-on to mirror and object. I don't see any need to integrate this in the community add-ons list. If you like it, just share it around you, people needing such kind of 1-second-saving tool will install it.
But as a default add-on, I don't see the point.
Also, I'm kind of skeptical about the "wide usage". I've seen it in some videos indeed (most of the authors are members of the forum that you quoted) and I obviously don't do any counting, but I don't have the feeling it is so widely used. (but I'd be glad if you can prove me that I'm wrong :)
I don't want to waste devs and moderators time.
Added subscriber: @cedriclepiller
Hello @Lapineige
Maybe a misunderstanding of my request on your github.
"I would like to add auto mirror to Blender 2.79" was a request from me for your permissions so I can put auto mirror into Blender Addons for 2.79 release.
I see your addon used by @cedriclepiller in his addons often & also adapted by MKB in his addons tool collections & also used myself in some of my addons collections.
It is no trouble for me to pep8 the addon.
I am the dev who will handle this addon, with code checks by lijenstina, which is why I created this task.
Initially I thought to merge this smaller utility addon into my mesh_extra_tools addon: https://developer.blender.org/T50680
After consideration, due mostly to the use in other addons, I thought it would be better as a standalone.
Maybe it would be better merged into mesh edit tools? what do you think?
I'm happy to close this task if your not happy with this, sorry if there was any misunderstanding of my request.
One note: you made this 3 years ago & people still use & know about auto mirror, this shows me that indeed it's a useful little addon.
Thanks, let me know what you would like to do. If it's ok, I will fix & add, if not, I will close this task.
Thanks.
Indeed, I thought you just wanted to install it on a 2.79 build. That's why I was surprised then.
But I was unclear: It surprised me, but it's GPL code, you do whatever you want with it. I just thought it would be kind to tell me before (just as a note)... and you made it by the way ^_^
I'm not here to "control" the integration of my piece of code, but I didn't want to waste devs time.
I've just read your activity history, it seems that you know what you are doing on this topic*, so I trust you if you thinks it would be good to integrate it.
And again, I'm flattered by this proposal :)
1 point for you :)
Honestly I don't really know what's the best option. I just asked on the forum you mentioned (if you read a bit of French, here is the discussion : http://blenderlounge.fr/forum/viewtopic.php?f=5&t=67&p=33129#p33129) what they think about it. I'll come back to you then.
Thanks for your time
hi @Lapineige,
I have read the blenderlounge forum posts & I think there is support there for auto mirror too'
It is best to have this addon as a standalone as the points wazou made are valid.
Initially I will commit the original to Blender Addons Contrib, from there I will make any needed changes for adding to Blender Then commit to release before 2.79.
Changes I think are needed:
File will be renamed to mesh_auto_mirror.py
pep8 & code clean up will follow. (this gives us a history & diffs back to the original in the blender Tracker system)
I'll also create a wiki page for the addon.
Then move to release for 2.79.
Thanks for your time too, I appreciate your support.
Integrating it to your add-on seems also logical and consistent, and would add it to a long list of useful tools.
But it's clear that for the users the change will be easier to understand.
I let you decide, you have more experience than me here.
It sounds like a good plan :)
If you need any help to update the code (for instance I'll remove the warning when no object is selected, it's useless and eyes-distracting) I'd be happy to help :)
Thanks again, I'm happy to know more users will benefit from my add-on.
Added subscriber: @VukGardasevic
@VukGardasevic if you have time could you check this please.
Thanks.
@Lapineige Thanks again, I'll follow this up quickly
Changed status from 'Open' to: 'Resolved'
closed as resolved.
committed.