No Milestone
No project
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender-addons#69148
Loading…
Reference in new issue
There is no content yet.
Delete Branch '%!s(<nil>)'
Deleting a branch is permanent. It CANNOT be undone. Continue?
HI I am a beginner I saw this task and I have made this addon-patch for the task https://developer.blender.org/T66299
newImg2plane.py
Added subscriber: @Calra
Added subscriber: @BrendonMurphy
hi, what are the benefits of your changes and what do they do?
@BrendonMurphy : Think this is about replacing the node setup with a principled shader [so it is better suited for exporting (OBJ, FBX, GLTF -- which rely on the Principled Shader to export textures along...)]
This might not be possible for the "shadeless" setup -- would at least need some further checking, but the for the others, using a principled shader should work out, I guess...
Hi @Calra !
Thx for your contribution!
Would you mind submitting this as a real patch (this would make it much easier for us in the review process)?
Have a look here https:*wiki.blender.org/wiki/Process/Contributing_Code and here https:*wiki.blender.org/wiki/Tools/Patches
You can just create a differential and attach it to #66299 (Addon "Import images as planes". change node system for better exprting to glTF), lets use this task for this since this is open already.
Hi thanks for replying I just read the Never do section, I didn't take permission from the authors' of this addon before editing. Should I do that before submitting the patch ?
Added subscriber: @mont29
Changed status from 'Open' to: 'Archived'
For sake of clarity, @Calra contacted me on blender.chat this morning, and gave the answer that anybody is free to modify that add-ons code within the licenses's conditions, as with any other piece of GPL software. What we forbid is committing changes to someone else's add-on without getting them reviewed first. Submitting patches is the way to go, and most welcomed.
@Calra will archive that task, we indeed need a proper differential one for review, as described by @lichtwerk above. Thanks.