Power sequencer select_all_left_or_right API change #84616

Closed
opened 2021-01-11 22:15:43 +01:00 by kreako · 5 comments

Blender Version
Broken: 2.90.1 2.91.0, 2.92.0 (API change was introduced in blender/blender@74fa600ede)
Worked: 2.83.x

Short description of error
On blender 2.91 and on latest revision, sequencer API for selection has changed. The operator POWER_SEQUENCER_OT_select_all_left_or_right should be updated.

On line 65 of power_sequencer/operators/select_all_left_or_right.py (https://developer.blender.org/diffusion/BA/browse/master/power_sequencer/operators/select_all_left_or_right.py$65), the line :

        return bpy.ops.sequencer.select("INVOKE_DEFAULT", left_right=self.side)

should be changed to :

        return bpy.ops.sequencer.select_side_of_frame("INVOKE_DEFAULT", side=self.side)

This minor change has been tested with blender 2.91 and is OK.

Without this change a stack trace will be displayed :

TypeError: Converting py args to operator properties: : keyword "left_right" unrecognized 
**Blender Version** Broken: 2.90.1 2.91.0, 2.92.0 (API change was introduced in blender/blender@74fa600ede) Worked: 2.83.x **Short description of error** On blender 2.91 and on latest revision, sequencer API for selection has changed. The operator `POWER_SEQUENCER_OT_select_all_left_or_right` should be updated. On line 65 of `power_sequencer/operators/select_all_left_or_right.py` (https://developer.blender.org/diffusion/BA/browse/master/power_sequencer/operators/select_all_left_or_right.py$65), the line : ``` return bpy.ops.sequencer.select("INVOKE_DEFAULT", left_right=self.side) ``` should be changed to : ``` return bpy.ops.sequencer.select_side_of_frame("INVOKE_DEFAULT", side=self.side) ``` This minor change has been tested with blender 2.91 and is OK. Without this change a stack trace will be displayed : ``` TypeError: Converting py args to operator properties: : keyword "left_right" unrecognized ```
Author

Added subscriber: @kreako

Added subscriber: @kreako

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Robert Guetzkow self-assigned this 2021-01-12 10:58:10 +01:00

Thank you for the report and suggested fix. If you would like to get involved in the development of Blender and have a patch ready to solve a problem, you can submit it for review as described on this page in the wiki.

Thank you for the report and suggested fix. If you would like to get involved in the development of Blender and have a patch ready to solve a problem, you can submit it for review as described on this [page in the wiki](https://wiki.blender.org/wiki/Tools/CodeReview#Upload_a_Diff).

This issue was referenced by 87889365fe

This issue was referenced by 87889365fe562e594fa989ef6315c001e2cbe63a

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#84616
No description provided.