blender/blender-addons
19
43
Fork 96
Code Issues 629 Pull Requests 27 Projects 1 Releases Wiki Activity

WIP add default library_name for unknown platforms #104492

Closed
Shane Ambler wants to merge 1 commits from ShaneAmbler/blender-addons:draco-libname into main
pull from: ShaneAmbler/blender-addons:draco-libname
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 2 Commits 1 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
io_scene_gltf2/io/com/gltf2_io_draco_compression_extension.py
View File

@ -33,7 +33,7 @@ def dll_path() -> Path:
'win32': '{}.dll'.format(lib_name), 'win32': '{}.dll'.format(lib_name),
'linux': 'lib{}.so'.format(lib_name), 'linux': 'lib{}.so'.format(lib_name),
'darwin': 'lib{}.dylib'.format(lib_name) 'darwin': 'lib{}.dylib'.format(lib_name)
}.get(sys.platform) }.get(sys.platform, 'lib{}.so'.format(lib_name))
if path is None or library_name is None: if path is None or library_name is None:
Julien Duroure commented 2024-05-24 15:59:02 +02:00
Review
Copy Link

Setting a default library name makes this check unrelevant

Setting a default library name makes this check unrelevant
print_console('WARNING', 'Unsupported platform {}, Draco mesh compression is unavailable'.format(sys.platform)) print_console('WARNING', 'Unsupported platform {}, Draco mesh compression is unavailable'.format(sys.platform))