blender/blender-addons
19
43
Fork 96
Code Issues 633 Pull Requests 27 Projects 1 Releases Wiki Activity

Storm Hydra render addon #104597

Merged
Brecht Van Lommel merged 22 commits from BogdanNagirniak/blender-addons:storm-hydra-addon into main 2023-08-04 17:02:11 +02:00
Conversation 0 Commits 22 Files Changed 4 +38 -2
4 changed files with 38 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a5da05eac1 - Show all commits

12
hydra_storm/engine.py
View File

@ -3,11 +3,13 @@
# <pep8 compliant> # <pep8 compliant>
from pathlib import Path
import bpy import bpy
from bpy_hydra import HydraRenderEngine import bpy_hydra
class StormHydraRenderEngine(HydraRenderEngine): class StormHydraRenderEngine(bpy_hydra.HydraRenderEngine):
bl_idname = 'StormHydraRenderEngine' bl_idname = 'StormHydraRenderEngine'
bl_label = "Hydra: Storm" bl_label = "Hydra: Storm"
brecht marked this conversation as resolved Outdated
Brecht Van Lommel commented 2023-05-10 18:57:45 +02:00
Outdated
Review
Copy Link

Hydra: Storm -> Hydra Storm

Hydra: Storm -> Hydra Storm
bl_info = "Hydra Storm (OpenGL) render delegate" bl_info = "Hydra Storm (OpenGL) render delegate"
brecht marked this conversation as resolved Outdated
Brecht Van Lommel commented 2023-05-10 18:58:15 +02:00
Outdated
Review
Copy Link

(OpenGL) is not accurate for Metal and Vulkan

(OpenGL) is not accurate for Metal and Vulkan
@ -17,6 +19,12 @@ class StormHydraRenderEngine(HydraRenderEngine):
delegate_id = 'HdStormRendererPlugin' delegate_id = 'HdStormRendererPlugin'
@classmethod
def register(cls):
super().register()
bpy_hydra.register_plugins([str(Path(__file__).parent / "plugin")], [])
def get_delegate_settings(self, engine_type): def get_delegate_settings(self, engine_type):
settings = bpy.context.scene.hydra_storm settings = bpy.context.scene.hydra_storm
return { return {

3
hydra_storm/plugin/plugInfo.json Normal file
View File

@ -0,0 +1,3 @@
{
"Includes": [ "usd/*/resources/" ]
}

22
hydra_storm/plugin/usd/hdStorm/resources/plugInfo.json Normal file
View File

@ -0,0 +1,22 @@
{
brecht marked this conversation as resolved Outdated
Brecht Van Lommel commented 2023-05-10 19:01:03 +02:00
Outdated
Review
Copy Link

This should already be included with the USD libraries, why is it here again?

This should already be included with the USD libraries, why is it here again?
Georgiy Markelov commented 2023-05-11 17:06:16 +02:00
Outdated
Review
Copy Link

We think it's better to bundle this folder with addon to be sure everything is needed here. But no problem if you think it's better to move it to blender.shared.

We think it's better to bundle this folder with addon to be sure everything is needed here. But no problem if you think it's better to move it to `blender.shared`.
Brecht Van Lommel commented 2023-05-11 18:14:20 +02:00
Outdated
Review
Copy Link

I would expected it's already in blender.shared?

It at least available to be copied there:
https://svn.blender.org/svnroot/bf-blender/trunk/lib/linux_x86_64_glibc_228/usd/plugin/usd/hdStorm/resources/

I would expected it's already in `blender.shared`? It at least available to be copied there: https://svn.blender.org/svnroot/bf-blender/trunk/lib/linux_x86_64_glibc_228/usd/plugin/usd/hdStorm/resources/
Georgiy Markelov commented 2023-05-12 11:56:18 +02:00
Outdated
Review
Copy Link

Yes, it was. Should we remove this folder here and add copying to blender.shared?

Yes, it was. Should we remove this folder here and add copying to `blender.shared`?
Brecht Van Lommel commented 2023-05-12 12:04:14 +02:00
Outdated
Review
Copy Link

Yes.

Yes.
"Plugins": [
{
"Info": {
"Types": {
"HdStormRendererPlugin": {
"bases": [
"HdRendererPlugin"
],
"displayName": "GL",
"priority": 0
}
}
},
"LibraryPath": "",
"Name": "hdStorm",
"ResourcePath": "resources",
"Root": "..",
"Type": "library"
}
]
}

3
hydra_storm/plugin/usd/plugInfo.json Normal file
View File

@ -0,0 +1,3 @@
{
"Includes": [ "*/resources/" ]
}