Fix #105045: Error importing FBX custom properties on placeholder PoseBones #105053

Thomas Barlow · 2023-12-09T03:21:19+01:00

Thomas Barlow commented

2023-12-09 03:21:19 +01:00

Caused by not understanding an uncommon import case in 716702b97e where
a bone can be created without an FBX Node to import custom properties
from.

A bone in Blender is always created from an FBX Node, so it seemed like
all bones should have an FBX Node that custom properties can be imported
from. However, FBX allows bone and non-bone Nodes to be parented to one
another, which Blender cannot represent exactly due to Armatures only
containing bones. In such cases, the non-bone Node is imported as an
Object, but a bone with the same name is also created (which the Object
is parented to). The newly created bone doesn't have a Node to import
custom properties from because the Node belongs to the imported Object
instead.

This is a request to backport f21b90cbab for Blender 4.0 with the conflicts in bl_info resolved.

Caused by not understanding an uncommon import case in 716702b97e where a bone can be created without an FBX Node to import custom properties from. A bone in Blender is always created from an FBX Node, so it seemed like all bones should have an FBX Node that custom properties can be imported from. However, FBX allows bone and non-bone Nodes to be parented to one another, which Blender cannot represent exactly due to Armatures only containing bones. In such cases, the non-bone Node is imported as an Object, but a bone with the same name is also created (which the Object is parented to). The newly created bone doesn't have a Node to import custom properties from because the Node belongs to the imported Object instead. --- This is a request to backport f21b90cbab for Blender 4.0 with the conflicts in `bl_info` resolved.

Thomas Barlow added 1 commit 2023-12-09 03:21:22 +01:00

Fix #105045 : Error importing FBX custom properties on placeholder PoseBones bb90c4fbcf

Caused by not understanding an uncommon import case in 716702b97e where
a bone can be created without an FBX Node to import custom properties
from.

A bone in Blender is always created from an FBX Node, so it seemed like
all bones should have an FBX Node that custom properties can be imported
from. However, FBX allows bone and non-bone Nodes to be parented to one
another, which Blender cannot represent exactly due to Armatures only
containing bones. In such cases, the non-bone Node is imported as an
Object, but a bone with the same name is also created (which the Object
is parented to). The newly created bone doesn't have a Node to import
custom properties from because the Node belongs to the imported Object
instead.

Thomas Barlow requested review from Bastien Montagne 2023-12-09 03:31:01 +01:00

Bastien Montagne approved these changes 2023-12-19 12:05:29 +01:00

Bastien Montagne referenced this pull request from blender/blender

2023-12-19 12:09:45 +01:00

4.0: Candidates for corrective releases #114706

Pratik Borhade commented

2024-01-05 11:56:39 +01:00

Hi, AFAIK there won't be another 4.0.x corrective release so we can close this PR :)