From 20b5fdf4d0c74d1c3b660cd1463b9d2f8460d74b Mon Sep 17 00:00:00 2001
From: tobiasHeinke <tobias.heinke@outlook.com>
Date: Fri, 22 Mar 2024 13:11:40 +0100
Subject: [PATCH 1/4] version switch: fix keyboard nav    from the jQuery drop
 (search outputted a list) fix on enter immediate nav to first link    the
 focus is moved from the button to the first link    so the browser navs on
 default

---
 build_files/theme/js/version_switch.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/build_files/theme/js/version_switch.js b/build_files/theme/js/version_switch.js
index 950d5839a..3dfdcb801 100644
--- a/build_files/theme/js/version_switch.js
+++ b/build_files/theme/js/version_switch.js
@@ -83,7 +83,7 @@ init() {
 		this.btn.classList.remove("wait");
 		this.btnOpenHandler();
 		this.btn.addEventListener("mousedown", function(e){that.btnOpenHandler(); e.preventDefault()});
-		this.btn.addEventListener("keydown", function(e){ if(that.btnKeyFilter(e)){that.btnOpenHandler();} });
+		this.btn.addEventListener("keydown", function(e){ if(that.btnKeyFilter(e)){that.btnOpenHandler();} e.preventDefault();});
 	});
 }
 warnOld(release, all_versions) {
@@ -246,14 +246,14 @@ keyMove(e) {
 	e.stopPropagation();
 }
 listPrev(nw) {
-	if (nw.parentNode.previousElementSibling.length !== 0) {
+	if (nw.parentNode.previousElementSibling) {
 		return nw.parentNode.previousElementSibling.firstElementChild;
 	} else {
 		return this.listLast();
 	}
 }
 listNext(nw) {
-	if (nw.parentNode.nextElementSibling.length !== 0) {
+	if (nw.parentNode.nextElementSibling) {
 		return nw.parentNode.nextElementSibling.firstElementChild;
 	} else {
 		return this.listFirst();
-- 
2.30.2


From 4d1f6d2229e0d74896c7482ceeb7e2be05d32b55 Mon Sep 17 00:00:00 2001
From: tobiasHeinke <tobias.heinke@outlook.com>
Date: Sat, 23 Mar 2024 14:29:16 +0100
Subject: [PATCH 2/4] move preventDefault into filter func for tab-key to work

---
 build_files/theme/js/version_switch.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build_files/theme/js/version_switch.js b/build_files/theme/js/version_switch.js
index 3dfdcb801..25e986702 100644
--- a/build_files/theme/js/version_switch.js
+++ b/build_files/theme/js/version_switch.js
@@ -83,7 +83,7 @@ init() {
 		this.btn.classList.remove("wait");
 		this.btnOpenHandler();
 		this.btn.addEventListener("mousedown", function(e){that.btnOpenHandler(); e.preventDefault()});
-		this.btn.addEventListener("keydown", function(e){ if(that.btnKeyFilter(e)){that.btnOpenHandler();} e.preventDefault();});
+		this.btn.addEventListener("keydown", function(e){ if(that.btnKeyFilter(e)){that.btnOpenHandler();e.preventDefault()}});
 	});
 }
 warnOld(release, all_versions) {
-- 
2.30.2


From 03166d82f550e61d8a7c8501f467f4c07f11f0c3 Mon Sep 17 00:00:00 2001
From: tobiasHeinke <tobias.heinke@outlook.com>
Date: Thu, 25 Apr 2024 13:49:31 +0200
Subject: [PATCH 3/4] remove dev residue

---
 build_files/templates/sidebar/variant-selector.html | 2 +-
 build_files/theme/js/version_switch.js              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/build_files/templates/sidebar/variant-selector.html b/build_files/templates/sidebar/variant-selector.html
index 9bf23d3b6..860a7fab3 100644
--- a/build_files/templates/sidebar/variant-selector.html
+++ b/build_files/templates/sidebar/variant-selector.html
@@ -2,7 +2,7 @@
   <ul id="versionwrap" role="presentation">
     <li role="presentation">
       <span id="version-popover" class="version-btn" tabindex="0" role="button" aria-label="versions selector"
-        aria-haspopup="true" aria-controls="version-vsnlist" aria-disabled="true">
+        aria-haspopup="true" aria-controls="version-vsnlist">
         {{ release }}
       </span>
       <div class="version-dialog" aria-hidden="true">
diff --git a/build_files/theme/js/version_switch.js b/build_files/theme/js/version_switch.js
index 25e986702..1b9ae08a4 100644
--- a/build_files/theme/js/version_switch.js
+++ b/build_files/theme/js/version_switch.js
@@ -58,7 +58,7 @@ init() {
 			})
 			.catch(() => {
 				console.error("Version Switch Error: versions.json could not be loaded.");
-				this.btn.classList.remove("disabled");
+				this.btn.classList.add("disabled");
 			});
 		} else {
 			resolve();
-- 
2.30.2


From e099054a8f0a27f1797f425e63073070f8a97c18 Mon Sep 17 00:00:00 2001
From: tobiasHeinke <tobias.heinke@outlook.com>
Date: Sat, 27 Apr 2024 12:23:00 +0200
Subject: [PATCH 4/4] fix unused loop exit was forEach function

---
 build_files/theme/js/version_switch.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build_files/theme/js/version_switch.js b/build_files/theme/js/version_switch.js
index 1b9ae08a4..e25d79443 100644
--- a/build_files/theme/js/version_switch.js
+++ b/build_files/theme/js/version_switch.js
@@ -153,7 +153,7 @@ getNamed(v) {
 			const m = title.match(/\d\.\d[\w\d\.]*/)[0];
 			if (parseFloat(m) == v) {
 				v = ix;
-				return false;
+				break;
 			}
 		}
 	};
-- 
2.30.2