From 9fcfd2e0761883c2910d2d4736ed21c084341d93 Mon Sep 17 00:00:00 2001
From: Alaska <alaskayou01@gmail.com>
Date: Tue, 4 Jun 2024 17:33:29 +1200
Subject: [PATCH 1/3] Add extra notes about ray portal BSDF 'limitations'

---
 manual/render/shader_nodes/shader/ray_portal.rst | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/manual/render/shader_nodes/shader/ray_portal.rst b/manual/render/shader_nodes/shader/ray_portal.rst
index d17d2e5f2..42f89f1ce 100644
--- a/manual/render/shader_nodes/shader/ray_portal.rst
+++ b/manual/render/shader_nodes/shader/ray_portal.rst
@@ -15,6 +15,14 @@ render passes are passed through,
 and it is affected by light path max transparent bounces.
 
 
+.. note::
+
+   - The portal only allows rays to pass through in one direction.
+
+   - Some of the techniques Cycles uses to reduce noise does not work through portals.
+     This leads to issues like increased noise from lights passing through portals,
+     or if the light is small, it's light may not pass through the portal.
+
 Inputs
 ======
 
-- 
2.30.2


From 2768dda530b826fe1ca81e05bfbc127767a6d59a Mon Sep 17 00:00:00 2001
From: Alaska <alaskayou01@gmail.com>
Date: Wed, 5 Jun 2024 02:16:16 +1200
Subject: [PATCH 2/3] Address Brecht's review

---
 manual/render/shader_nodes/shader/ray_portal.rst | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/manual/render/shader_nodes/shader/ray_portal.rst b/manual/render/shader_nodes/shader/ray_portal.rst
index 42f89f1ce..6fc51b39f 100644
--- a/manual/render/shader_nodes/shader/ray_portal.rst
+++ b/manual/render/shader_nodes/shader/ray_portal.rst
@@ -14,14 +14,15 @@ It acts much like a :doc:`Transparent BSDF </render/shader_nodes/shader/transpar
 render passes are passed through,
 and it is affected by light path max transparent bounces.
 
-
 .. note::
 
-   - The portal only allows rays to pass through in one direction.
+   - The Ray Portal BSDF only allows rays to pass through it in one direction. Add a
+     second portal at the target location to make rays go in the other direction as well.
+
+   - Light sampling does not work efficiently through portals. This can lead to increased
+     noised from lights on the other side of portals. Particularly small lights may be very
+     noisy, or not pass through at all.
 
-   - Some of the techniques Cycles uses to reduce noise does not work through portals.
-     This leads to issues like increased noise from lights passing through portals,
-     or if the light is small, it's light may not pass through the portal.
 
 Inputs
 ======
-- 
2.30.2


From 3c3f88c242e5f89045c074dd6471e3a1bd01b20c Mon Sep 17 00:00:00 2001
From: Alaska <alaskayou01@gmail.com>
Date: Wed, 5 Jun 2024 02:22:40 +1200
Subject: [PATCH 3/3] Fix spelling

---
 manual/render/shader_nodes/shader/ray_portal.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/manual/render/shader_nodes/shader/ray_portal.rst b/manual/render/shader_nodes/shader/ray_portal.rst
index 6fc51b39f..21a79bfc4 100644
--- a/manual/render/shader_nodes/shader/ray_portal.rst
+++ b/manual/render/shader_nodes/shader/ray_portal.rst
@@ -20,7 +20,7 @@ and it is affected by light path max transparent bounces.
      second portal at the target location to make rays go in the other direction as well.
 
    - Light sampling does not work efficiently through portals. This can lead to increased
-     noised from lights on the other side of portals. Particularly small lights may be very
+     noise from lights on the other side of portals. Particularly small lights may be very
      noisy, or not pass through at all.
 
 
-- 
2.30.2