GPencil: framechanging does not evaluate keyframed layer transform correctly (if this would result in identity matrix) #101164

New Issue

Piotr Nikov · 2022-09-18T13:10:56+02:00

Piotr Nikov commented

2022-09-18 13:10:56 +02:00

System Information
Operating system: MacOs 12.6
Graphics card: M1

Blender Version
Broken: 3.4.0 (3.4.0 2022-09-17)
Worked: ?

Short description of error
When animating Grease Pencil Transforms in Stroke Properties, there is a refresh problem (it doesn't refresh) when going back to first frame of animation using Jump to first frame ...
Workaround seems to be clicking a keyframe in the Dopesheet.

Exact steps for others to reproduce the error

Open attached file
Drag playhead away from 0th frame (say 20)
Press Jump to Previous keyframe button from timeline header
(notice viewport doesn't update. Clicking anywhere in dopsheet later updates the viewport)

Kapture 2022-09-18 at 12.59.55.mp4
AnimatedGP_Transform_Refresh_Bug.blend

Seems to only be the case with exactly 0° rotation?
If I change the first rotation keyframe to have a value of 1°, this all of a sudden seems to work fine:
AnimatedGP_Transform_Refresh_Bug_repro.blend

going to / going from zero rotation goes wrong:
gpencil_layer_transform_zero_rotation_.blend

**System Information** Operating system: MacOs 12.6 Graphics card: M1 **Blender Version** Broken: 3.4.0 (3.4.0 2022-09-17) Worked: ? **Short description of error** When animating Grease Pencil Transforms in Stroke Properties, there is a refresh problem (it doesn't refresh) when going back to first frame of animation using Jump to first frame ... Workaround seems to be clicking a keyframe in the Dopesheet. **Exact steps for others to reproduce the error** - Open attached file - Drag playhead away from 0th frame (say 20) - Press `Jump to Previous keyframe` button from timeline header (notice viewport doesn't update. Clicking anywhere in dopsheet later updates the viewport) [Kapture 2022-09-18 at 12.59.55.mp4](https://archive.blender.org/developer/F13506367/Kapture_2022-09-18_at_12.59.55.mp4) [AnimatedGP_Transform_Refresh_Bug.blend](https://archive.blender.org/developer/F13506368/AnimatedGP_Transform_Refresh_Bug.blend) Seems to only be the case with exactly 0° rotation? If I change the first rotation keyframe to have a value of 1°, this all of a sudden seems to work fine: [AnimatedGP_Transform_Refresh_Bug_repro.blend](https://archive.blender.org/developer/F13526286/AnimatedGP_Transform_Refresh_Bug_repro.blend) going to / going from zero rotation goes wrong: [gpencil_layer_transform_zero_rotation_.blend](https://archive.blender.org/developer/F13526538/gpencil_layer_transform_zero_rotation_.blend)

Piotr Nikov commented

2022-09-18 13:10:56 +02:00

Added subscriber: @Pyer

blender-admin commented

2022-09-18 13:10:56 +02:00

#101325 was marked as duplicate of this issue

Piotr Nikov commented

2022-09-18 13:14:49 +02:00

Added subscriber: @antoniov

Pratik Borhade commented

2022-09-19 05:18:48 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-09-19 05:18:51 +02:00

Added subscriber: @PratikPB2123

Amélie Fondevilla commented

2022-09-19 09:54:53 +02:00

Added subscriber: @amelief

Amélie Fondevilla commented

2022-09-19 09:54:53 +02:00

I am not sure I understand the issue.
If the issue is that we cannot see the keyframes in the dopesheet, that is because the dopesheet is in 'Grease Pencil' mode, and thus only displaying layer keyframes (meaning drawn keyframes, and not transform or gpencil data keyframes). If you switch to the standard mode of the dopesheet, you can see that the keyframes are correctly created.

I am not sure I understand the issue. If the issue is that we cannot see the keyframes in the dopesheet, that is because the dopesheet is in 'Grease Pencil' mode, and thus only displaying layer keyframes (meaning drawn keyframes, and not transform or gpencil data keyframes). If you switch to the standard mode of the dopesheet, you can see that the keyframes are correctly created.![Capture d’écran du 2022-09-19 09-42-43.png](https://archive.blender.org/developer/F13512892/Capture_d_écran_du_2022-09-19_09-42-43.png)

Piotr Nikov commented

2022-09-19 10:02:32 +02:00

Hello! The issue is that when animating a Grease Pencil Transform, when you press the Icon to go to the first frame of the animation (or jump to previous/next key) the viewport does not refresh the animated GP transform (timecode 00:17 in the video).
It refreshes the viewport when you click anywhere in the Dopesheet window (GP or normal).

Hello! The issue is that when animating a Grease Pencil Transform, when you press the Icon to go to the first frame of the animation (or jump to previous/next key) ![Screenshot 2022-09-19 at 09.59.59.png](https://archive.blender.org/developer/F13512933/Screenshot_2022-09-19_at_09.59.59.png) the viewport does not refresh the animated GP transform (timecode 00:17 in the video). It refreshes the viewport when you click anywhere in the Dopesheet window (GP or normal).

Pratik Borhade changed title from ~~Animated GreasePencil transform refresh bug~~ to GPencil: Jump to previous keyframe doesn't update the viewport for transform properties

2022-09-19 10:07:30 +02:00

Philipp Oeser commented

2022-09-20 10:36:10 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-09-20 10:36:10 +02:00

Jumping to next seems to go fine on my side.
Could it be that this is only the case with exactly 0° rotation?
If I change the first rotation keyframe to have a value of 1°, this all of a sudden seems to work fine:
AnimatedGP_Transform_Refresh_Bug_repro.blend

Jumping to next seems to go fine on my side. Could it be that this is only the case with exactly 0° rotation? If I change the first rotation keyframe to have a value of 1°, this all of a sudden seems to work fine: [AnimatedGP_Transform_Refresh_Bug_repro.blend](https://archive.blender.org/developer/F13526286/AnimatedGP_Transform_Refresh_Bug_repro.blend)

Piotr Nikov commented

2022-09-20 10:41:22 +02:00

@lichtwerk
Haha you're right!! So weird!!!

@lichtwerk Haha you're right!! So weird!!!

Philipp Oeser commented

2022-09-20 10:48:40 +02:00

So this is true for all framechanging (mouse, frame offset, frame jump, ..)
Seems like greasepencil is just not evaluating right for zero rotation keyframes

So this is true for **all** framechanging (mouse, frame offset, frame jump, ..) Seems like greasepencil is just not evaluating right for zero rotation keyframes

Philipp Oeser changed title from ~~GPencil: Jump to previous keyframe doesn't update the viewport for transform properties~~ to GPencil: framechanging does not evaluate keyframed layer transform rotation of exactly zero degrees correctly

2022-09-20 10:51:03 +02:00

Piotr Nikov commented

2022-09-20 11:25:46 +02:00

@lichtwerk
Oh wait it actually does the same thing with Location, you have to put a different value than zero for it to refresh correctly...
Scaling seems to be ok.

@lichtwerk Oh wait it actually does the same thing with Location, you have to put a different value than zero for it to refresh correctly... Scaling seems to be ok.

Philipp Oeser self-assigned this 2022-09-20 11:27:10 +02:00

Philipp Oeser commented

2022-09-20 11:27:10 +02:00

Ah, there are (optimization checks for this in BKE_gpencil_prepare_eval_data & BKE_gpencil_update_layer_transforms
Will check on a fix

Ah, there are (optimization checks for this in `BKE_gpencil_prepare_eval_data` & `BKE_gpencil_update_layer_transforms` Will check on a fix

Philipp Oeser changed title from ~~GPencil: framechanging does not evaluate keyframed layer transform rotation of exactly zero degrees correctly~~ to GPencil: framechanging does not evaluate keyframed layer transform correctly (if this would result in identity matrix)

2022-09-20 11:28:30 +02:00

blender-admin commented

2022-09-20 12:11:56 +02:00

This issue was referenced by dfcc8086fb

This issue was referenced by dfcc8086fb29745fe533088452797fd2ef39df25

blender-admin commented

2022-09-20 12:11:56 +02:00

This issue was referenced by 24814a03b7

This issue was referenced by 24814a03b7345184ba5a87e03015c70eb40c31bf

blender-admin commented

2022-09-20 12:11:56 +02:00

This issue was referenced by 1cbfe04638

This issue was referenced by 1cbfe0463879fb3dde7e10f151b5ef24008bd211

Piotr Nikov commented

2022-09-22 07:40:42 +02:00

@lichtwerk Hello and sorry for asking, but is this going to be published to master at some point? I'm still not seeing it in the recent nightly builds. Thanks :)